Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add start to SSM json schemas #3471

Merged
merged 1 commit into from
Jul 15, 2024

Conversation

kddejong
Copy link
Contributor

@kddejong kddejong commented Jul 6, 2024

Issue #, if available:
#2728

Description of changes:

  • Add rule E3051 to validate SSM document structure

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Copy link

codecov bot commented Jul 6, 2024

Codecov Report

Attention: Patch coverage is 96.55172% with 1 line in your changes missing coverage. Please review.

Project coverage is 93.40%. Comparing base (ee6271f) to head (f0e592e).

Files Patch % Lines
src/cfnlint/rules/resources/ssm/Document.py 96.55% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3471      +/-   ##
==========================================
- Coverage   93.40%   93.40%   -0.01%     
==========================================
  Files         325      326       +1     
  Lines       11087    11116      +29     
  Branches     2327     2331       +4     
==========================================
+ Hits        10356    10383      +27     
  Misses        410      410              
- Partials      321      323       +2     
Flag Coverage Δ
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kddejong kddejong force-pushed the fix/issue/2728 branch 4 times, most recently from 809f012 to 73f7d57 Compare July 7, 2024 17:07
@kddejong kddejong merged commit 4e28934 into aws-cloudformation:main Jul 15, 2024
22 checks passed
@kddejong kddejong deleted the fix/issue/2728 branch July 15, 2024 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant