Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update helpers.py with DocDB snapshot type #3455

Merged
merged 2 commits into from
Jul 2, 2024
Merged

Update helpers.py with DocDB snapshot type #3455

merged 2 commits into from
Jul 2, 2024

Conversation

marty-sullivan
Copy link
Contributor

Issue #, if available:

N/A

Description of changes:

DocumentDB Clusters support DeletionPolicy and UpdateReplacePolicy of type Snapshot

https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-attribute-deletionpolicy.html

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Copy link

codecov bot commented Jul 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.29%. Comparing base (36ff520) to head (f32bb62).
Report is 1 commits behind head on main.

Current head f32bb62 differs from pull request most recent head 5a871ff

Please upload reports for the commit 5a871ff to get more accurate results.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3455      +/-   ##
==========================================
- Coverage   93.30%   93.29%   -0.01%     
==========================================
  Files         324      324              
  Lines       11055    11055              
  Branches     2316     2316              
==========================================
- Hits        10315    10314       -1     
  Misses        415      415              
- Partials      325      326       +1     
Flag Coverage Δ
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kddejong kddejong merged commit 0a1db38 into aws-cloudformation:main Jul 2, 2024
20 checks passed
@marty-sullivan marty-sullivan deleted the docdb-snapshot branch July 2, 2024 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants