Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Load registry schemas if type match #3450

Merged
merged 4 commits into from
Jul 2, 2024

Conversation

kddejong
Copy link
Contributor

Issue #, if available:
fix #3446

Description of changes:

  • Don't normalize resource types if we load the type from the registry schema parameter
  • Update rule E3019 to not validate primary identifiers if there are none

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Copy link

codecov bot commented Jun 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.29%. Comparing base (36ff520) to head (90c4363).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3450      +/-   ##
==========================================
- Coverage   93.30%   93.29%   -0.01%     
==========================================
  Files         324      324              
  Lines       11055    11058       +3     
  Branches     2316     2318       +2     
==========================================
+ Hits        10315    10317       +2     
  Misses        415      415              
- Partials      325      326       +1     
Flag Coverage Δ
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kddejong kddejong merged commit 2e2034c into aws-cloudformation:main Jul 2, 2024
21 checks passed
@kddejong kddejong deleted the fix/issue/3446 branch July 2, 2024 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

E3019 failing for code module since update
1 participant