Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert json resource properties into better json schem validation #3423

Merged
merged 2 commits into from
Jun 27, 2024

Conversation

kddejong
Copy link
Contributor

@kddejong kddejong commented Jun 26, 2024

Issue #, if available:
#3403

Description of changes:

  • Convert all json type elements to support "object" and "string" and add "format": "json" so we can validate the string as valid json
  • Patch in tag properties that are only looking for "type": "object" with the Key/Value definition

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@kddejong kddejong force-pushed the fix/data/jsonobjects branch from 8220aa1 to 60309a5 Compare June 26, 2024 23:48
Copy link

codecov bot commented Jun 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.35%. Comparing base (1e78b4c) to head (656499b).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3423      +/-   ##
==========================================
- Coverage   93.36%   93.35%   -0.01%     
==========================================
  Files         323      323              
  Lines       11031    11031              
  Branches     2309     2309              
==========================================
- Hits        10299    10298       -1     
  Misses        408      408              
- Partials      324      325       +1     
Flag Coverage Δ
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kddejong kddejong force-pushed the fix/data/jsonobjects branch from 60309a5 to 3d10651 Compare June 27, 2024 04:53
@kddejong kddejong force-pushed the fix/data/jsonobjects branch from 3d10651 to 656499b Compare June 27, 2024 13:39
@kddejong kddejong merged commit 3001eb5 into aws-cloudformation:main Jun 27, 2024
22 checks passed
@kddejong kddejong deleted the fix/data/jsonobjects branch June 27, 2024 14:00
@kddejong kddejong restored the fix/data/jsonobjects branch June 27, 2024 21:18
@kddejong kddejong deleted the fix/data/jsonobjects branch June 27, 2024 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant