Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Ref AWS::NoValue in FindInMap parameters #3399

Merged
merged 1 commit into from
Jun 25, 2024

Conversation

kddejong
Copy link
Contributor

@kddejong kddejong commented Jun 25, 2024

Issue #, if available:
fix #3396
Description of changes:

  • Allow Ref AWS::NoValue in FindInMap parameters

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Copy link

codecov bot commented Jun 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.20%. Comparing base (5d5e6c8) to head (8e6dffb).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3399      +/-   ##
==========================================
- Coverage   93.23%   93.20%   -0.04%     
==========================================
  Files         323      323              
  Lines       11005    11016      +11     
  Branches     2299     2301       +2     
==========================================
+ Hits        10261    10267       +6     
- Misses        415      417       +2     
- Partials      329      332       +3     
Flag Coverage Δ
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kddejong kddejong merged commit ed39a19 into aws-cloudformation:main Jun 25, 2024
21 of 22 checks passed
@kddejong kddejong deleted the fix/issue/3396 branch June 25, 2024 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

E1011 when FindInMap DefaultValue is AWS::NoValue
1 participant