Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add rules for security group validation #3026

Merged
merged 4 commits into from
Jan 22, 2024
Merged

Add rules for security group validation #3026

merged 4 commits into from
Jan 22, 2024

Conversation

kddejong
Copy link
Contributor

@kddejong kddejong commented Jan 21, 2024 •
edited
Loading

Issue #, if available:
#2999

Description of changes:

  • Add rule E3687 to validate ToPort and FromPort are specified when certain protocols are used
  • Add rule W3687 to validate ToPort and FromPort aren't specified when certain protocols are used
  • Add rule E3688 to validate both ToPort,FromPort are -1 when one is specified as -1
  • Update specs as of 2024/01/21

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@kddejong kddejong force-pushed the fix/issue/2999 branch 2 times, most recently from f033ae7 to 2667e66 Compare January 21, 2024 21:35
@kddejong kddejong merged commit 090d2af into aws-cloudformation:v1 Jan 22, 2024
21 checks passed
@kddejong kddejong deleted the fix/issue/2999 branch January 22, 2024 16:38
kddejong added a commit that referenced this pull request Jan 23, 2024
@kddejong
Add rules for security group validation (#3026)
434e0c5 
* Add rule E3687 to validate ToPort and FromPort
* Add rule W3687 to validate ToPort and FromPort
* Add rule E3688 to validate both ToPort,FromPort are -1
* Apply the rules to Ingress and Egress resources
kddejong added a commit to kddejong/cfn-python-lint that referenced this pull request Feb 5, 2024
@kddejong
Add rules for security group validation (aws-cloudformation#3026)
3060091 
* Add rule E3687 to validate ToPort and FromPort
* Add rule W3687 to validate ToPort and FromPort
* Add rule E3688 to validate both ToPort,FromPort are -1
* Apply the rules to Ingress and Egress resources
kddejong added a commit that referenced this pull request Feb 5, 2024
@kddejong
Add rules for security group validation (#3026)
a66d840 
* Add rule E3687 to validate ToPort and FromPort
* Add rule W3687 to validate ToPort and FromPort
* Add rule E3688 to validate both ToPort,FromPort are -1
* Apply the rules to Ingress and Egress resources
kddejong added a commit to kddejong/cfn-python-lint that referenced this pull request Feb 5, 2024
@kddejong
Add rules for security group validation (aws-cloudformation#3026)
d9b337e 
* Add rule E3687 to validate ToPort and FromPort
* Add rule W3687 to validate ToPort and FromPort
* Add rule E3688 to validate both ToPort,FromPort are -1
* Apply the rules to Ingress and Egress resources
kddejong added a commit to kddejong/cfn-python-lint that referenced this pull request Feb 7, 2024
@kddejong
Add rules for security group validation (aws-cloudformation#3026)
ae28149 
* Add rule E3687 to validate ToPort and FromPort
* Add rule W3687 to validate ToPort and FromPort
* Add rule E3688 to validate both ToPort,FromPort are -1
* Apply the rules to Ingress and Egress resources
kddejong added a commit to kddejong/cfn-python-lint that referenced this pull request Feb 7, 2024
@kddejong
Add rules for security group validation (aws-cloudformation#3026)
abc0335 
* Add rule E3687 to validate ToPort and FromPort
* Add rule W3687 to validate ToPort and FromPort
* Add rule E3688 to validate both ToPort,FromPort are -1
* Apply the rules to Ingress and Egress resources
kddejong added a commit that referenced this pull request Feb 16, 2024
@kddejong
Add rules for security group validation (#3026)
4f7602a 
* Add rule E3687 to validate ToPort and FromPort
* Add rule W3687 to validate ToPort and FromPort
* Add rule E3688 to validate both ToPort,FromPort are -1
* Apply the rules to Ingress and Egress resources
kddejong added a commit that referenced this pull request Feb 16, 2024
@kddejong
Add rules for security group validation (#3026)
c9eee36 
* Add rule E3687 to validate ToPort and FromPort
* Add rule W3687 to validate ToPort and FromPort
* Add rule E3688 to validate both ToPort,FromPort are -1
* Apply the rules to Ingress and Egress resources
kddejong added a commit that referenced this pull request Feb 27, 2024
@kddejong
Add rules for security group validation (#3026)
50cde19 
* Add rule E3687 to validate ToPort and FromPort
* Add rule W3687 to validate ToPort and FromPort
* Add rule E3688 to validate both ToPort,FromPort are -1
* Apply the rules to Ingress and Egress resources
kddejong added a commit that referenced this pull request Mar 4, 2024
@kddejong
Add rules for security group validation (#3026)
0afe8d1 
* Add rule E3687 to validate ToPort and FromPort
* Add rule W3687 to validate ToPort and FromPort
* Add rule E3688 to validate both ToPort,FromPort are -1
* Apply the rules to Ingress and Egress resources
kddejong added a commit that referenced this pull request Mar 12, 2024
@kddejong
Add rules for security group validation (#3026)
03c5a5b 
* Add rule E3687 to validate ToPort and FromPort
* Add rule W3687 to validate ToPort and FromPort
* Add rule E3688 to validate both ToPort,FromPort are -1
* Apply the rules to Ingress and Egress resources
kddejong added a commit to kddejong/cfn-python-lint that referenced this pull request Apr 4, 2024
@kddejong
Add rules for security group validation (aws-cloudformation#3026)
8e16ed0 
* Add rule E3687 to validate ToPort and FromPort
* Add rule W3687 to validate ToPort and FromPort
* Add rule E3688 to validate both ToPort,FromPort are -1
* Apply the rules to Ingress and Egress resources
kddejong added a commit that referenced this pull request Apr 5, 2024
@kddejong
Add rules for security group validation (#3026)
0ea81d1 
* Add rule E3687 to validate ToPort and FromPort
* Add rule W3687 to validate ToPort and FromPort
* Add rule E3688 to validate both ToPort,FromPort are -1
* Apply the rules to Ingress and Egress resources
kddejong added a commit that referenced this pull request Apr 15, 2024
@kddejong
Add rules for security group validation (#3026)
a12dfe8 
* Add rule E3687 to validate ToPort and FromPort
* Add rule W3687 to validate ToPort and FromPort
* Add rule E3688 to validate both ToPort,FromPort are -1
* Apply the rules to Ingress and Egress resources
kddejong added a commit that referenced this pull request Apr 18, 2024
@kddejong
Add rules for security group validation (#3026)
3278d20 
* Add rule E3687 to validate ToPort and FromPort
* Add rule W3687 to validate ToPort and FromPort
* Add rule E3688 to validate both ToPort,FromPort are -1
* Apply the rules to Ingress and Egress resources
kddejong added a commit that referenced this pull request Apr 25, 2024
@kddejong
Add rules for security group validation (#3026)
179fc0c 
* Add rule E3687 to validate ToPort and FromPort
* Add rule W3687 to validate ToPort and FromPort
* Add rule E3688 to validate both ToPort,FromPort are -1
* Apply the rules to Ingress and Egress resources
kddejong added a commit that referenced this pull request Apr 26, 2024
@kddejong
Add rules for security group validation (#3026)
26fa3e7 
* Add rule E3687 to validate ToPort and FromPort
* Add rule W3687 to validate ToPort and FromPort
* Add rule E3688 to validate both ToPort,FromPort are -1
* Apply the rules to Ingress and Egress resources
kddejong added a commit that referenced this pull request May 2, 2024
@kddejong
Add rules for security group validation (#3026)
a60acf1 
* Add rule E3687 to validate ToPort and FromPort
* Add rule W3687 to validate ToPort and FromPort
* Add rule E3688 to validate both ToPort,FromPort are -1
* Apply the rules to Ingress and Egress resources
kddejong added a commit that referenced this pull request May 3, 2024
@kddejong
Add rules for security group validation (#3026)
559c9b6 
* Add rule E3687 to validate ToPort and FromPort
* Add rule W3687 to validate ToPort and FromPort
* Add rule E3688 to validate both ToPort,FromPort are -1
* Apply the rules to Ingress and Egress resources
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@kddejong