Validate scheduling strategy for Fargate services #2559
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lejiati
force-pushed
the
service
branch
2 times, most recently
from
e6fddde to
0538ed5
Compare
PatMyron
reviewed
Jan 23, 2023
test/fixtures/templates/good/resources/ecs/test_fargate_scheduling_strategy.yaml
Outdated
Show resolved
Hide resolved
…ling_strategy.yaml Co-authored-by: Pat Myron <[email protected]>
kddejong
requested changes
Jan 27, 2023
src/cfnlint/rules/resources/ecs/FargateDeploymentSchedulingStrategy.py
Outdated
Show resolved
Hide resolved
Change: Intrinsic functions can be used for resource properties and previously this rule checker doesn't handle such scenario.
kddejong
approved these changes
Feb 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#1547
Description of changes:
This change adds a new rule validating scheduling strategy for Fargate services
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.