Rule E3042 - Check at least one essential container is specified #1548
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1548 +/- ##
==========================================
+ Coverage 87.60% 87.61% +0.01%
==========================================
Files 160 161 +1
Lines 8873 8898 +25
Branches 2124 2129 +5
==========================================
+ Hits 7773 7796 +23
- Misses 660 661 +1
- Partials 440 441 +1
Continue to review full report at Codecov.
|
|
@kddejong is there a better way to test rules that won't run afoul of Codecov? It seems the majority of rules employ the same method for testing, but it doesn't give good coverage. |
PatMyron
reviewed
May 24, 2020
src/cfnlint/rules/resources/ecs/TaskDefinitionEssentialContainer.py
Outdated
Show resolved
Hide resolved
PatMyron
approved these changes
May 24, 2020
|
template syntax edge cases are handled well because they evaluate to true 👍 Parameters:
Parameter:
Type: String
Resources:
TaskDefinition:
Type: AWS::ECS::TaskDefinition
Properties:
ContainerDefinitions:
- Image: Image
Name: Name
Memory: 100
Essential: !Ref Parameter |
PatMyron
reviewed
May 24, 2020
src/cfnlint/rules/resources/ecs/TaskDefinitionEssentialContainer.py
Outdated
Show resolved
Hide resolved
|
@Tro95 thanks for the new rule, documentation will be automatically generated right before the next release! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: #1547
Description of changes: Adds a new rule, E3042, that checks
AWS::ECS::TaskDefinition.ContainerDefinitionspecifies at least one essential container. Not specifying an essential container (or having a container defaulting to essential) will cause a deployment failure. Reference: https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-properties-ecs-taskdefinition-containerdefinitions.html#cfn-ecs-taskdefinition-containerdefinition-essential.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.