Clean up retention period on rds instance (#3172)

aws-cloudformation · Apr 26, 2024 · a9e75ef · a9e75ef
1 parent 95a7b79
commit a9e75ef
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 2 deletions.
diff --git a/src/cfnlint/data/schemas/extensions/aws_rds_dbinstance/backupretentionperiod.json b/src/cfnlint/data/schemas/extensions/aws_rds_dbinstance/backupretentionperiod.json
@@ -4,7 +4,8 @@
    "Engine": {
     "pattern": "^(?!aurora).*$",
     "type": "string"
-   }
+   },
+   "SourceDBInstanceIdentifier": false
   },
   "required": [
    "Engine"

diff --git a/test/unit/rules/resources/test_retentionperiod_rds.py b/test/unit/rules/resources/test_retentionperiod_rds.py
@@ -50,10 +50,15 @@ def validator():
     "name,instance,expected",
     [
         (
-            "Valid version",
+            "Valid retention period",
             {"MessageRetentionPeriod": "90"},
             [],
         ),
+        (
+            "Valid with SourceDBInstanceIdentifier",
+            {"SourceDBInstanceIdentifier": "source-db"},
+            [],
+        ),
         (
             "Invalid when not specified",
             {