Update E1010 lang ext function support (#3817)

aws-cloudformation · Nov 8, 2024 · 9d83f3f · 9d83f3f
1 parent 76c134c
commit 9d83f3f
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 5 deletions.
diff --git a/src/cfnlint/rules/functions/GetAtt.py b/src/cfnlint/rules/functions/GetAtt.py
@@ -32,23 +32,32 @@ def __init__(self) -> None:
         super().__init__("Fn::GetAtt", all_types)
 
     def schema(self, validator, instance) -> dict[str, Any]:
-        resource_functions = []
+        resource_name_functions = []
+        resource_attribute_functions = ["Ref"]
         if validator.context.transforms.has_language_extensions_transform():
-            resource_functions = ["Ref"]
+            resource_name_functions = resource_attribute_functions = [
+                "Ref",
+                "Fn::Base64",
+                "Fn::FindInMap",
+                "Fn::Sub",
+                "Fn::If",
+                "Fn::Join",
+                "Fn::ToJsonString",
+            ]
 
         return {
             "type": ["string", "array"],
             "minItems": 2,
             "maxItems": 2,
             "fn_items": [
                 {
-                    "functions": resource_functions,
+                    "functions": resource_name_functions,
                     "schema": {
                         "type": ["string"],
                     },
                 },
                 {
-                    "functions": ["Ref"],
+                    "functions": resource_attribute_functions,
                     "schema": {
                         "type": ["string"],
                     },

diff --git a/test/unit/rules/functions/test_getatt.py b/test/unit/rules/functions/test_getatt.py
@@ -202,7 +202,7 @@ def validate(self, validator, s, instance, schema):
         ),
         (
             "Valid Ref in GetAtt for attribute",
-            {"Fn::GetAtt": ["MyBucket", {"Ref": "MyAttributeParameter"}]},
+            {"Fn::GetAtt": ["MyBucket", {"Fn::Sub": "${MyAttributeParameter}"}]},
             {"type": "string"},
             _template_with_transform,
             {},