don't create empty files

.github/workflows/maintenance-v1.yaml

@@ -25,7 +25,7 @@ jobs:
           cfn-lint --update-documentation
           scripts/update_specs_from_pricing.py
           scripts/update_serverless_aws_policies.py
-          scripts/update_schemas_from_boto.py
+          scripts/boto/update_schemas_from_boto.py
           scripts/update_schemas_from_aws_api.py
           cfn-lint --update-specs
           echo "date=$(date +'%Y-%m-%d')" >> $GITHUB_OUTPUT

scripts/boto/_manual_patches.py

@@ -28,16 +28,6 @@
             shape="BrokerStorageType",
         ),
     },
-    "AWS::AmazonMQ::Configuration": {
-        "/properties/AuthenticationStrategy": Patch(
-            source=["mq", "2017-11-27"],
-            shape="AuthenticationStrategy",
-        ),
-        "/properties/EngineType": Patch(
-            source=["mq", "2017-11-27"],
-            shape="EngineType",
-        ),
-    },
     "AWS::ApiGateway::RestApi": {
         "/properties/ApiKeySourceType": Patch(
             source=["apigateway", "2015-07-09"],
@@ -57,10 +47,6 @@
         ),
     },
     "AWS::ApplicationAutoScaling::ScalingPolicy": {
-        "/properties/PolicyType": Patch(
-            source=["application-autoscaling", "2016-02-06"],
-            shape="PolicyType",
-        ),
         (
             "/definitions/PredefinedMetricSpecification/"
             "properties/PredefinedMetricType"
@@ -385,12 +371,6 @@
             shape="StreamViewType",
         ),
     },
-    "AWS::EC2::CustomerGateway": {
-        "/properties/Type": Patch(
-            source=["ec2", "2016-11-15"],
-            shape="GatewayType",
-        ),
-    },
     "AWS::EC2::EC2Fleet": {
         "/definitions/OnDemandOptionsRequest/properties/AllocationStrategy": Patch(
             source=["ec2", "2016-11-15"],

scripts/boto/update_schemas_from_boto.py

@@ -56,45 +56,47 @@ def build_resource_type_patches(
 
     output_file = resource_path / "boto.json"
 
-    with open(output_file, "w+") as fh:
-        d = []
-        boto_d = {}
-        for path, patch in resource_patches.items():
-            service_path = (
-                ["botocore-master/botocore/data"] + patch.source + ["service-2.json"]
-            )
-            with open(os.path.join(dir, *service_path), "r") as f:
-                boto_d = json.load(f)
-
-                for field in ["enum", "pattern"]:
-                    value = boto_d.get("shapes", {}).get(patch.shape, {}).get(field)
-                    if not value:
+    d = []
+    boto_d = {}
+    for path, patch in resource_patches.items():
+        service_path = (
+            ["botocore-master/botocore/data"] + patch.source + ["service-2.json"]
+        )
+        with open(os.path.join(dir, *service_path), "r") as f:
+            boto_d = json.load(f)
+
+            for field in ["enum", "pattern"]:
+                value = boto_d.get("shapes", {}).get(patch.shape, {}).get(field)
+                if not value:
+                    continue
+                if field == "pattern":
+                    if value == ".*":
                         continue
-                    if field == "pattern":
-                        if value == ".*":
-                            continue
-                        try:
-                            re.compile(value)
-                        except Exception:
-                            LOGGER.info(
-                                (
-                                    f"Pattern {value!r} failed to "
-                                    "compile for resource "
-                                    f"{resource_name!r}"
-                                )
+                    try:
+                        re.compile(value)
+                    except Exception:
+                        LOGGER.info(
+                            (
+                                f"Pattern {value!r} failed to "
+                                "compile for resource "
+                                f"{resource_name!r}"
                             )
-                            continue
-                    if value:
-                        d.append(
-                            {
-                                "op": "add",
-                                "path": f"{path}/{field}",
-                                "value": (
-                                    sorted(value) if isinstance(value, list) else value
-                                ),
-                            }
                         )
-
+                        continue
+                if value:
+                    d.append(
+                        {
+                            "op": "add",
+                            "path": f"{path}/{field}",
+                            "value": (
+                                sorted(value) if isinstance(value, list) else value
+                            ),
+                        }
+                    )
+
+    if not d:
+        return
+    with open(output_file, "w+") as fh:
         json.dump(
             d,
             fh,

src/cfnlint/data/schemas/patches/extensions/all/aws_applicationautoscaling_scalingpolicy/boto.json

@@ -1,12 +1,4 @@
 [
- {
-  "op": "add",
-  "path": "/properties/PolicyType/enum",
-  "value": [
-   "StepScaling",
-   "TargetTrackingScaling"
-  ]
- },
  {
   "op": "add",
   "path": "/definitions/PredefinedMetricSpecification/properties/PredefinedMetricType/enum",
@@ -94,5 +86,13 @@
    "sagemaker:variant:DesiredProvisionedConcurrency",
    "workspaces:workspacespool:DesiredUserSessions"
   ]
+ },
+ {
+  "op": "add",
+  "path": "/properties/PolicyType/enum",
+  "value": [
+   "StepScaling",
+   "TargetTrackingScaling"
+  ]
  }
 ]