Fix type checking in if/then

aws-cloudformation · Jul 12, 2024 · 6f89afd · 6f89afd
1 parent 31054c6
commit 6f89afd
Show file tree

Hide file tree

Showing 2 changed files with 38 additions and 15 deletions.
diff --git a/src/cfnlint/data/schemas/extensions/aws_ecs_taskdefinition/fargate_properties.json b/src/cfnlint/data/schemas/extensions/aws_ecs_taskdefinition/fargate_properties.json
@@ -16,27 +16,42 @@
   ]
  },
  "then": {
+  "if": {
+   "properties": {
+    "Cpu": {
+     "type": [
+      "string",
+      "integer"
+     ]
+    }
+   },
+   "required": [
+    "Cpu"
+   ]
+  },
   "not": {
    "required": [
     "PlacementConstraints"
    ]
   },
-  "properties": {
-   "Cpu": {
-    "enum": [
-     256,
-     512,
-     1024,
-     2048,
-     4096,
-     8192,
-     16384
-    ]
-   }
-  },
   "required": [
    "Cpu",
    "Memory"
-  ]
+  ],
+  "then": {
+   "properties": {
+    "Cpu": {
+     "enum": [
+      256,
+      512,
+      1024,
+      2048,
+      4096,
+      8192,
+      16384
+     ]
+    }
+   }
+  }
  }
 }
diff --git a/test/unit/rules/resources/ecs/test_ecs_task_fargate_properties.py b/test/unit/rules/resources/ecs/test_ecs_task_fargate_properties.py
@@ -75,6 +75,14 @@ def rule():
                 )
             ],
         ),
+        (
+            {
+                "RequiresCompatibilities": ["FARGATE"],
+                "Cpu": {"Ref": "MyParameter"},
+                "Memory": "512",
+            },
+            [],
+        ),
         (
             {
                 "RequiresCompatibilities": ["FARGATE"],
@@ -87,7 +95,7 @@ def rule():
                     rule=TaskFargateProperties(),
                     path=deque(["Cpu"]),
                     validator="enum",
-                    schema_path=deque(["then", "properties", "Cpu", "enum"]),
+                    schema_path=deque(["then", "then", "properties", "Cpu", "enum"]),
                 )
             ],
         ),