Add some more tests

aws-cloudformation · Oct 24, 2024 · 6b0cde5 · 6b0cde5
1 parent dd724bf
commit 6b0cde5
Showing 1 changed file with 126 additions and 29 deletions.
diff --git a/test/unit/rules/resources/properties/test_enum.py b/test/unit/rules/resources/properties/test_enum.py
@@ -7,42 +7,139 @@
 
 import pytest
 
-from cfnlint.context import Path
+from cfnlint.jsonschema import ValidationError
 from cfnlint.rules.parameters.Enum import Enum as ParameterEnum
 from cfnlint.rules.resources.properties.Enum import Enum
 
 
-@pytest.fixture(scope="module")
+@pytest.fixture
 def rule():
     rule = Enum()
     rule.child_rules["W2030"] = ParameterEnum()
     yield Enum()
 
 
-def test_validate(rule, validator):
-    assert len(list(rule.enum(validator, ["foo", "bar"], "foo", {}))) == 0
-    assert len(list(rule.enum(validator, ["foo"], "bar", {}))) == 1
-
-    evolved = validator.evolve(
-        context=validator.context.evolve(
-            path=Path(path=deque(["Fn::Sub"])),
-        )
-    )
-    errs = list(rule.enum(evolved, ["bar"], "bar", {}))
-    assert len(errs) == 0
-
-    evolved = validator.evolve(
-        context=validator.context.evolve(
-            path=Path(
-                path=deque(["Ref"]),
-                value_path=deque(["Parameters", "MyParameter", "Default"]),
-            ),
-        )
-    )
-    errs = list(rule.enum(evolved, ["foo"], "bar", {}))
-    assert len(errs) == 1
-    assert errs[0].rule.id == ParameterEnum.id
-
-    rule.child_rules["W2030"] = None
-    errs = list(rule.enum(evolved, ["foo"], "bar", {}))
-    assert len(errs) == 0
+@pytest.fixture
+def template():
+    return {
+        "Parameters": {
+            "MyString": {
+                "Type": "String",
+                "Default": "a",
+                "AllowedValues": ["a", "b"],
+            },
+        },
+        "Resources": {},
+    }
+
+
+@pytest.mark.parametrize(
+    "name,instance,enums,path,expected",
+    [
+        (
+            "Validate the standard enum",
+            "a",
+            ["a"],
+            {},
+            [],
+        ),
+        (
+            "Validate the standard enum",
+            "a",
+            ["a"],
+            {"value_path": ["Parameters", "MyString", "AllowedValues", 0]},
+            [],
+        ),
+        (
+            "Invalid with the standard enum",
+            "a",
+            ["b"],
+            {},
+            [
+                ValidationError(
+                    ("'a' is not one of ['b']"),
+                    path=deque([]),
+                    schema_path=deque([]),
+                    path_override=deque([]),
+                ),
+            ],
+        ),
+        (
+            "Invalid with the standard enum from parameter",
+            "a",
+            ["b"],
+            {"value_path": ["Parameters", "MyString", "AllowedValues", 0]},
+            [
+                ValidationError(
+                    ("'a' is not one of ['b']"),
+                    path=deque([]),
+                    schema_path=deque([]),
+                    rule=ParameterEnum(),
+                    path_override=deque(["Parameters", "MyString", "AllowedValues", 0]),
+                ),
+            ],
+        ),
+    ],
+    indirect=["path"],
+)
+def test_validate_enum(name, instance, enums, expected, rule, validator):
+    errs = list(rule.enum(validator, enums, instance, {}))
+
+    assert errs == expected, f"Test {name!r} got {errs!r}"
+
+
+@pytest.mark.parametrize(
+    "name,instance,enums,path,expected",
+    [
+        (
+            "Validate the standard enum",
+            "a",
+            ["A"],
+            {},
+            [],
+        ),
+        (
+            "Validate the standard enum",
+            "a",
+            ["A"],
+            {"value_path": ["Parameters", "MyString", "AllowedValues", 0]},
+            [],
+        ),
+        (
+            "Invalid with the standard enum",
+            "a",
+            ["B"],
+            {},
+            [
+                ValidationError(
+                    ("'a' is not one of ['b'] (case-insensitive)"),
+                    path=deque([]),
+                    schema_path=deque([]),
+                    path_override=deque([]),
+                ),
+            ],
+        ),
+        (
+            "Invalid with the standard enum from parameter",
+            "a",
+            ["B"],
+            {"value_path": ["Parameters", "MyString", "AllowedValues", 0]},
+            [
+                ValidationError(
+                    ("'a' is not one of ['b'] (case-insensitive)"),
+                    path=deque([]),
+                    schema_path=deque([]),
+                    rule=ParameterEnum(),
+                    path_override=deque(["Parameters", "MyString", "AllowedValues", 0]),
+                ),
+            ],
+        ),
+    ],
+    indirect=["path"],
+)
+def test_validate_enum_case_insensitive(
+    name, instance, enums, expected, rule, validator
+):
+    errs = list(rule.enumCaseInsensitive(validator, enums, instance, {}))
+
+    assert errs == expected, f"Test {name!r} got {errs!r}"