Make sure resource types are strings before assuming (#3025)

src/cfnlint/rules/resources/PrimaryIdentifiers.py

@@ -127,7 +127,9 @@ def _validate_resource_type_uniqueness(self, cfn, resource_type, ids):
     def match(self, cfn):
         tS = set()
         for _, resource_properties in cfn.get_resources().items():
-            tS.add(resource_properties.get("Type"))
+            t = resource_properties.get("Type")
+            if isinstance(t, str):
+                tS.add(t)
 
         matches = []
         for t in tS:

src/cfnlint/rules/resources/properties/Properties.py

@@ -72,7 +72,7 @@ def cfnresourceproperties(self, validator: Validator, _, instance: Any, schema):
         )
 
         t = instance.get("Type")
-        if not t:
+        if not validator.is_type(t, "string"):
             return
 
         if t.startswith("Custom::"):

test/fixtures/templates/bad/resources/primary_identifiers.yaml

@@ -152,3 +152,5 @@ Resources:
         - IsUsEast1
         - us-east-1
         - !Ref 'AWS::NoValue'
+  BadType:
+    Type: !Ref AWS::Region