Allow capital letters for rule W3687 (#3345)

aws-cloudformation · Jun 20, 2024 · 4c3a445 · 4c3a445
1 parent c2a5e74
commit 4c3a445
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 1 deletion.
diff --git a/...lint/data/schemas/extensions/aws_ec2_securitygroup/protocols_and_port_ranges_exclude.json b/...lint/data/schemas/extensions/aws_ec2_securitygroup/protocols_and_port_ranges_exclude.json
@@ -12,7 +12,10 @@
       "tcp",
       17,
       "17",
-      "udp"
+      "udp",
+      "TCP",
+      "UDP",
+      "ICMP"
      ]
     },
     "type": [

diff --git a/test/unit/rules/resources/ec2/test_sg_protocols_ports_exclusive.py b/test/unit/rules/resources/ec2/test_sg_protocols_ports_exclusive.py
@@ -34,6 +34,12 @@ def rule():
             },
             [],
         ),
+        (
+            {
+                "IpProtocol": "TCP",
+            },
+            [],
+        ),
         (
             [],  # wrong type
             [],
-Original file line number
+Diff line change
@@ Expand Up / @@ -12,7 +12,10 @@ @@
           "tcp",
 ,
           "17",
-          "udp"
+          "udp",
+          "TCP",
+          "UDP",
+          "ICMP"
          ]
         },
         "type": [
@@ Expand Down @@