-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RFC 0011: Allow Intrinsic Functions and Pseudo-Parameter References in DeletionPolicy and UpdateReplacePolicy RFC #21
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lejiati
previously approved these changes
May 4, 2022
mluk-aws
previously approved these changes
May 4, 2022
gunach
reviewed
May 5, 2022
gunach
reviewed
May 5, 2022
MalikAtalla-AWS
previously approved these changes
May 6, 2022
e8ce0c9
gunach
previously approved these changes
May 6, 2022
jlhood
requested changes
May 6, 2022
PatMyron
reviewed
May 10, 2022
jlhood
requested changes
May 12, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Requesting some minor edits. Otherwise, looks really good!
We had to recreate this PR because the fork it was based on was detached when we switched this repo to public. This RFC can now be tracked here: #74 |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Language Enhancement Request For Comment
This is a request for comments about allowing Intrinsic Functions and Pseudo-Parameter References in
DeletionPolicy
andUpdateReplacePolicy
Resource Attributes RFC. See #11 for additional details.Licensing
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.