Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFC 0011: Allow Intrinsic Functions and Pseudo-Parameter References in DeletionPolicy and UpdateReplacePolicy RFC #21

Closed
wants to merge 4 commits into from

Conversation

mingujo
Copy link
Contributor

@mingujo mingujo commented May 2, 2022

Language Enhancement Request For Comment

This is a request for comments about allowing Intrinsic Functions and Pseudo-Parameter References in DeletionPolicy and UpdateReplacePolicy Resource Attributes RFC. See #11 for additional details.


Licensing

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@mingujo mingujo added the approved RFC PR approved by CFN engineers label May 2, 2022
@mingujo mingujo self-assigned this May 2, 2022
lejiati
lejiati previously approved these changes May 4, 2022
mluk-aws
mluk-aws previously approved these changes May 4, 2022
RFCs/0011-DeletionPolicy.md Outdated Show resolved Hide resolved
RFCs/0011-DeletionPolicy.md Outdated Show resolved Hide resolved
@mingujo mingujo assigned MalikAtalla-AWS and unassigned mingujo May 6, 2022
MalikAtalla-AWS
MalikAtalla-AWS previously approved these changes May 6, 2022
RFCs/0011-DeletionPolicy.md Outdated Show resolved Hide resolved
@mingujo mingujo dismissed stale reviews from MalikAtalla-AWS, mluk-aws, and lejiati via e8ce0c9 May 6, 2022 20:03
gunach
gunach previously approved these changes May 6, 2022
RFCs/0011-DeletionPolicy.md Outdated Show resolved Hide resolved
RFCs/0011-DeletionPolicy.md Outdated Show resolved Hide resolved
RFCs/0011-DeletionPolicy.md Outdated Show resolved Hide resolved
RFCs/0011-DeletionPolicy.md Outdated Show resolved Hide resolved
RFCs/0011-DeletionPolicy.md Outdated Show resolved Hide resolved
RFCs/0011-DeletionPolicy.md Outdated Show resolved Hide resolved
RFCs/0011-DeletionPolicy.md Outdated Show resolved Hide resolved
RFCs/0011-DeletionPolicy.md Outdated Show resolved Hide resolved
RFCs/0011-DeletionPolicy.md Outdated Show resolved Hide resolved
@lejiati lejiati removed the approved RFC PR approved by CFN engineers label May 9, 2022
Copy link
Contributor

@jlhood jlhood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requesting some minor edits. Otherwise, looks really good!

RFCs/0011-DeletionPolicy.md Show resolved Hide resolved
RFCs/0011-DeletionPolicy.md Show resolved Hide resolved
RFCs/0011-DeletionPolicy.md Show resolved Hide resolved
RFCs/0011-DeletionPolicy.md Show resolved Hide resolved
RFCs/0011-DeletionPolicy.md Show resolved Hide resolved
RFCs/0011-DeletionPolicy.md Show resolved Hide resolved
RFCs/0011-DeletionPolicy.md Show resolved Hide resolved
RFCs/0011-DeletionPolicy.md Show resolved Hide resolved
RFCs/0011-DeletionPolicy.md Show resolved Hide resolved
@MalikAtalla-AWS
Copy link
Contributor

We had to recreate this PR because the fork it was based on was detached when we switched this repo to public. This RFC can now be tracked here: #74

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants