[Integration]Adding the initial Integration resource #487
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wbkang
requested review from
moataz-mhmd and
khebul
and removed request for
moataz-mhmd
wbkang
force-pushed
the
integration-resource
branch
2 times, most recently
from
2514331 to
2d4608c
Compare
moataz-mhmd
changed the title
moataz-mhmd
reviewed
Nov 21, 2023
aws-rds-integration/src/main/java/software/amazon/rds/integration/ListHandler.java
Show resolved
Hide resolved
aws-rds-integration/src/main/java/software/amazon/rds/integration/DeleteHandler.java
Outdated
Show resolved
Hide resolved
aws-rds-integration/src/main/java/software/amazon/rds/integration/BaseHandlerStd.java
Outdated
Show resolved
Hide resolved
aws-rds-integration/src/main/java/software/amazon/rds/integration/BaseHandlerStd.java
Outdated
Show resolved
Hide resolved
wbkang
force-pushed
the
integration-resource
branch
from
d4702ab to
28c7802
Compare
moataz-mhmd
reviewed
Nov 21, 2023
aws-rds-integration/src/main/java/software/amazon/rds/integration/DeleteHandler.java
Outdated
Show resolved
Hide resolved
moataz-mhmd
reviewed
Nov 21, 2023
aws-rds-integration/src/main/java/software/amazon/rds/integration/UpdateHandler.java
Show resolved
Hide resolved
wbkang
force-pushed
the
integration-resource
branch
from
28c7802 to
3849b75
Compare
moataz-mhmd
reviewed
Nov 23, 2023
aws-rds-integration/src/main/java/software/amazon/rds/integration/IntegrationStatusUtil.java
Show resolved
Hide resolved
wbkang
force-pushed
the
integration-resource
branch
2 times, most recently
from
4df6ec4 to
9b5bb56
Compare
wbkang
force-pushed
the
integration-resource
branch
3 times, most recently
from
3f38e0f to
6a4c611
Compare
moataz-mhmd
previously approved these changes
Nov 29, 2023
wbkang
force-pushed
the
integration-resource
branch
4 times, most recently
from
67fc20e to
adca009
Compare
|
Can you add the maven-verify workflow to github actions for the resource? |
wbkang
force-pushed
the
integration-resource
branch
from
adca009 to
1a24f9a
Compare
|
I've added maven-verify workflow in the latest update. |
moataz-mhmd
approved these changes
Dec 8, 2023
khebul
approved these changes
Dec 11, 2023
Contract tests are passing. Co-authored-by: Valentin Shirshov <[email protected]>
wbkang
force-pushed
the
integration-resource
branch
from
1a24f9a to
699d512
Compare
dbbh
pushed a commit
to dbbh/aws-cloudformation-resource-providers-rds
that referenced
this pull request
Dec 28, 2023
…oudformation#487) Contract tests are passing. Co-authored-by: Valentin Shirshov <[email protected]>
dbbh
pushed a commit
to dbbh/aws-cloudformation-resource-providers-rds
that referenced
this pull request
Dec 29, 2023
…oudformation#487) Contract tests are passing. Co-authored-by: Valentin Shirshov <[email protected]>
dbbh
pushed a commit
to dbbh/aws-cloudformation-resource-providers-rds
that referenced
this pull request
Jan 2, 2024
…oudformation#487) Contract tests are passing. Co-authored-by: Valentin Shirshov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: #485
Description of changes:
This is an initial version of the Integration resource. It does have good unit test coverage, and I've done some very minimal testing but contract testing is not passing yet.
I'd like to have this reviewed and committed so we can make smaller PRs in the future.
The implementation was co-authored by @khebul (recorded in the commit as well).