Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Set up integ tests on gh actions #229

Merged
merged 14 commits into from
Sep 12, 2023
Merged

chore: Set up integ tests on gh actions #229

merged 14 commits into from
Sep 12, 2023

Conversation

thaddmt
Copy link
Contributor

@thaddmt thaddmt commented Aug 16, 2023

Description of changes

❯ ghast -d .github/workflows
AUXI missing CODEOWNERS file which can provide additional protections for your workflow files.
AUXI missing SECURITY.md file which is crucial for researchers looking to report a finding.
FILE => coverage.yml
WARN check_for_inline_script
WARN check_for_non_github_managed_actions

FILE => publish.yml

FILE => codeql.yml
WARN check_for_non_github_managed_actions

FILE => callable-e2e-test.yml
WARN check_for_upload_download_artifact_action
WARN check_for_inline_script
WARN check_for_non_github_managed_actions

FILE => callable-e2e-tests.yml

Summary
The following Actions failed to pass one or more checks:
 • .github/workflows/coverage.yml
 • .github/workflows/codeql.yml
 • .github/workflows/callable-e2e-test.yml
  • Update the environment secret to use a PAT from our amplify-ui-automation account (currently using my personal one only for testing)

Issue #, if available

Description of how you validated changes

Checklist

  • PR description included
  • yarn test passes
  • Tests are [changed or added]
  • Relevant documentation is changed or added (and PR referenced)

@thaddmt thaddmt requested a review from a team as a code owner August 16, 2023 21:32
@thaddmt thaddmt requested a review from stocaaro August 16, 2023 21:39
@codecov-commenter
Copy link

codecov-commenter commented Aug 16, 2023

Codecov Report

Merging #229 (2bb3334) into main (0e359a8) will not change coverage.
The diff coverage is n/a.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@           Coverage Diff           @@
##             main     #229   +/-   ##
=======================================
  Coverage   43.99%   43.99%           
=======================================
  Files          16       16           
  Lines        1273     1273           
  Branches      201      201           
=======================================
  Hits          560      560           
  Misses        713      713           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@stocaaro
Copy link
Member

Ghast looks really cool. We received feedback from AppSec to do static analysis on a few security areas, which I added as a JS script. We might be able to replace this with Ghast, but I think we would need security review for this tool before turning it on.

Don't see anything concerning here. Has this work been through security review yet?

package.json Outdated Show resolved Hide resolved
@thaddmt
Copy link
Contributor Author

thaddmt commented Aug 17, 2023

Ghast looks really cool. We received feedback from AppSec to do static analysis on a few security areas, which I added as a JS script. We might be able to replace this with Ghast, but I think we would need security review for this tool before turning it on.

Don't see anything concerning here. Has this work been through security review yet?

I actually received a recommendation to use this tool from appsec!

@thaddmt thaddmt requested a review from stocaaro August 17, 2023 17:23
@thaddmt thaddmt requested a review from wlee221 August 25, 2023 13:32
@thaddmt thaddmt merged commit 1b078de into main Sep 12, 2023
@github-actions
Copy link

🎉 This PR is included in version 3.0.0-geo.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Copy link

github-actions bot commented Nov 9, 2023

🎉 This PR is included in version 3.0.0-unstable.10 🎉

The release is available on:

Your semantic-release bot 📦🚀

Copy link

🎉 This PR is included in version 4.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants