chore(auth): add js passwordless changes #8129
Open
+400
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jjarvisp
reviewed
Nov 22, 2024
src/pages/[platform]/build-a-backend/auth/manage-users/manage-webauthn-credentials/index.mdx
Outdated
Show resolved
Hide resolved
src/pages/[platform]/build-a-backend/auth/connect-your-frontend/sign-in/index.mdx
Show resolved
Hide resolved
…webauthn-credentials/index.mdx Co-authored-by: James Jarvis <[email protected]>
josefaidt
reviewed
Nov 25, 2024
Comment on lines
1147
to
1148
| username: state.username, | ||
| password: state.password, |
There was a problem hiding this comment.
can we use placeholder strings for these?
There was a problem hiding this comment.
Do you mean a variable with a placeholder string or string literals with a consistent placeholder string?
There was a problem hiding this comment.
string literals, similar to https://docs.amplify.aws/react/build-a-backend/auth/connect-your-frontend/sign-in/#using-the-signin-api
josefaidt
reviewed
Nov 25, 2024
src/pages/[platform]/build-a-backend/auth/connect-your-frontend/sign-in/index.mdx
Outdated
Show resolved
Hide resolved
…d/sign-in/index.mdx Co-authored-by: josef <[email protected]>
scanlonp
commented
Nov 25, 2024
| @@ -589,6 +591,7 @@ Following sign in, you will receive a `nextStep` in the sign-in result of one of | |||
| | `CONFIRM_SIGN_IN_WITH_TOTP_CODE` | The sign-in must be confirmed with a TOTP code from the user. Complete the process with `confirmSignIn`. | | |||
| | `CONFIRM_SIGN_IN_WITH_SMS_CODE` | The sign-in must be confirmed with a SMS code from the user. Complete the process with `confirmSignIn`. | | |||
| | `CONFIRM_SIGN_IN_WITH_EMAIL_CODE` | The sign-in must be confirmed with a EMAIL code from the user. Complete the process with `confirmSignIn`. | | |||
| | `CONFIRM_SIGN_IN_WITH_PASSWORD` | The sign-in must be confirmed with the password from the user. Complete the process with `confirmSignIn`. | | |||
There was a problem hiding this comment.
@jjarvisp, is there a case where CONTINUE_SIGN_IN_WITH_FIRST_FACTOR_SELECTION could be the result of a confirmSignIn call?
There was a problem hiding this comment.
Yes, confirmSignIn() calls RespondToAuthChallenge which could potentially return a SELECT_CHALLENGE challenge.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Add js passwordless changes for all APIs.
Related GitHub issue #, if available:
Instructions
If this PR should not be merged upon approval for any reason, please submit as a DRAFT
Which product(s) are affected by this PR (if applicable)?
Which platform(s) are affected by this PR (if applicable)?
Please add the product(s)/platform(s) affected to the PR title
Checks
Does this PR conform to the styleguide?
Does this PR include filetypes other than markdown or images? Please add or update unit tests accordingly.
Are any files being deleted with this PR? If so, have the needed redirects been created?
Are all links in MDX files using the MDX link syntax rather than HTML link syntax?
ref: MDX:
[link](https://docs.amplify.aws/)HTML:
<a href="https://docs.amplify.aws/">link</a>When this PR is ready to merge, please check the box below
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.