You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
Do we have a ticket to follow up with an app directory test later?
@reesscot Good question. I'm not sure if it's worth it to test that since Nextjs 11 is little an old version. I added it as a question in the design doc so that we can discuss it later
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Issue: Mega-app react-17-next-11-node-16-ts started to fail since May 5. https://github.com/aws-amplify/amplify-ui/actions/runs/4887947902/jobs/8725120905?pr=3751
Reason: On May 4, create-next-app released a change (vercel/next.js#49111) to ask a interactive question on command line to for the App Router and set the default to
YesFix: This PR is to add a
--no-appflag so that it'll create apages/folder instead of aapp/folder.Issue #, if available
Description of how you validated changes
POC PR: #3751
Checklist
yarn testpasses and tests are updated/addedsideEffectsfield updatedBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.