Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(build system): add React tests for loadtest 2 #3755

Merged
merged 112 commits into from
Apr 19, 2023
Merged

test(build system): add React tests for loadtest 2 #3755

merged 112 commits into from
Apr 19, 2023

Conversation

0618
Copy link
Contributor

@0618 0618 commented Apr 19, 2023 •
edited
Loading

Description of changes

#3703 was reverted in #3753 , so redo the loadtest PR with Github Workflow permission fix.

Issue #, if available

Description of how you validated changes

Tested in #3751

Checklist

  • Have read the Pull Request Guidelines
  • PR description included
  • Relevant documentation is changed or added (and PR referenced)
  • yarn test passes and tests are updated/added
  • No side effects or sideEffects field updated

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

0618 added 30 commits April 5, 2023 22:05
@0618
test(build system):setup env
8496a72
@0618
test(build system): add cra-template-react-js
3f0cc3a
@0618
test(build system): add script/create-react-app
b098755
@0618
test(build system): add script/create-react-app args
49b2395
@0618
test(build system): create template folder
ae82631
@0618
test(build system): create template components
de53be0
@0618
test(build system): mega-apps folder
3d00368
@0618
test(build system): add react-16-cra-5-js
94265c3
@0618
test(build system): dynamically create react16 and 18 js
5bf4ae3
@0618
test(build system): refactor create-react-app script
c3c4504
@0618
test(build system): create-react-app to create react 16 ts
ee45b9c
@0618
test(build system): rename cra-template-react
aa60f6f
@0618
test(build system): cleanup template/src
a487d7b
@0618
test(build system): create mega-apps folder
549a6fb
@0618
test(build system): rename pkgManager
5fef867
@0618
PoC: add mega app canary workflow
4a7a938
@0618
PoC: add mega app canary workflow trigger
8cefbb6
@0618
revert to build-and-runtime-test
1a0f1cf
@0618
use personal amplify app
1bdddf0
@0618
use personal amplify app
6873c9b
@0618
use personal amplify app
537095f
@0618
change mega-apps-test trigger by push
37ec22a
@0618
change amplify pull envName
46863a2
@0618
remove unnecessary steps
f32b9eb
@0618
try building mega-app
a0b5b1d
@0618
fix amplify pull
c4794d5
@0618
install esbuild-register
0ea4f84
@0618
install esbuild-register
aef0207
@0618
fix working-dir
a22fb8f
@0618
log current dir
d0c9ba5
@0618 0618 requested a review from a team as a code owner April 19, 2023 23:11
@changeset-bot
Copy link

changeset-bot bot commented Apr 19, 2023 •
edited
Loading

⚠️ No Changeset found

Latest commit: fa9166e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

0618
0618 commented Apr 19, 2023
View reviewed changes
.github/workflows/build-system-test.yml
name: Build System Test Canary

permissions:
id-token: write # This is required for aws-actions/configure-aws-credentials
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

L5 and L6 is the only difference from #3703

@0618 0618 changed the title Mega app canary react test(build system): add React tests for loadtest Apr 19, 2023
@0618 0618 changed the title test(build system): add React tests for loadtest test(build system): add React tests for loadtest 2 Apr 19, 2023
@0618 0618 temporarily deployed to ci April 19, 2023 23:36 — with GitHub Actions Inactive
@0618 0618 temporarily deployed to ci April 19, 2023 23:36 — with GitHub Actions Inactive
@0618 0618 temporarily deployed to ci April 19, 2023 23:36 — with GitHub Actions Inactive
@0618 0618 temporarily deployed to ci April 19, 2023 23:36 — with GitHub Actions Inactive
@0618 0618 merged commit 0b8c9c3 into main Apr 19, 2023
@0618 0618 deleted the mega-app-canary-react branch April 19, 2023 23:59
0618 added a commit that referenced this pull request Apr 20, 2023
@0618
Revert "test(build system): add React tests for loadtest 2 (#3755)"
9ace99c 
This reverts commit 0b8c9c3.
@0618 0618 mentioned this pull request Apr 20, 2023
Merged
0618 added a commit that referenced this pull request Apr 20, 2023
@0618
Revert "test(build system): add React tests for loadtest 2 (#3755)" (#…
a7c2f04 
…3756)

This reverts commit 0b8c9c3.
@0618 0618 mentioned this pull request May 2, 2023
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reesscot reesscot reesscot approved these changes

@wlee221 wlee221 wlee221 approved these changes

@ioanabrooks ioanabrooks ioanabrooks approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@0618 @reesscot @wlee221 @ioanabrooks