Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test(build system): add React tests for loadtest #3703
test(build system): add React tests for loadtest #3703
Changes from 99 commits
8496a72
3f0cc3a
b098755
49b2395
ae82631
de53be0
3d00368
94265c3
5bf4ae3
c3c4504
ee45b9c
aa60f6f
a487d7b
549a6fb
5fef867
4a7a938
8cefbb6
1a0f1cf
1bdddf0
6873c9b
537095f
37ec22a
46863a2
f32b9eb
a0b5b1d
c4794d5
0ea4f84
aef0207
a22fb8f
d0c9ba5
c2ec45f
069a5ec
9b9d571
ea4ab4a
9a7e5ce
688f6f9
9e2ec8e
d68287f
bb48084
55471b5
41d10cf
8fd7bee
d450b3f
c5ea445
5b5fbe7
8e1f6f4
a6314ce
8503afc
64f973e
e7ae2d8
63be58b
add5e00
3603565
dfbc9ee
2ad6fe9
aab93af
16b9809
601d138
e149c7b
825084e
483007a
a95adab
6222e9c
89169e4
8af6262
eaeca4e
40e1ea6
4498428
9d008c6
346309b
2ce99b8
40a4c96
d890948
e1d6e90
2ffed94
bb82b25
ba89b5d
9c1f0f6
57f96fd
a18e62f
bf0c576
5b6bd75
818a822
6813234
f58003a
f7b85b2
28e260a
5980a04
e0030b6
5f8f02b
df2f057
3b8c871
e8516b7
ce15ddf
d977d5c
42fbf13
00f3cc2
6848a58
445a021
9c6662a
44b2e08
86ea30a
16b8f00
578fbea
223e7a2
4433be9
ac7253d
49ddde9
8a10691
6a010a1
35a17df
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It doesn't run every 15 minutes since it's not merged to the default branch (
main
) yet. (doc)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I love the simplification here!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Eventually, we'll have to set up CW alarms against this test -- when do you expect to do this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, good point...Let me cut a ticket for that
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What about
to mimic our documentation code?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
or
user?.username
if above isn't TS strict compliant.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Our docs would have a type error. We have to either set a default value or add a question mark like
user?.username
😂There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's add a question mark for now. Let's add a ticket for updating our docs for TS strict customers.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done 3f68159
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit, but spacing seems off. Can you run prettier?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done 3f68159
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is
@ts-nocheck
necessary?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
otherwise there would be a lot of red marks in VS Code.
That might be a good point. Would that prevent some necessary build failures if there's any TS issue?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
since we're interested in catching TS errors, let's remove it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we use relative path instead of
@/
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@/
was from the auto-generated config. Since we try to mimic the users behavior, it might be better not change itThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Understood, not blocking then.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm good with leaving
tsconfig
as-is then, but let's use relative path in the import statement, since that's what we use in docs.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's a good catch. The newer version of Next.js auto generated the relative path as default, so I kept it here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is
typescript
meant to be pinned?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch. I'll test and address it in the real PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done 3f68159