chore: update crypto-js to @4 in aws-amplify@latest #8273
Conversation
|
This pull request introduces 1 alert when merging 937ff85 into 6528037 - view on LGTM.com new alerts:
|
| @@ -19,6 +19,7 @@ import { | |||
| SortPredicatesGroup, | |||
| SortDirection, | |||
| } from './types'; | |||
| import { WordArray } from 'amazon-cognito-identity-js'; | |||
There was a problem hiding this comment.
should this appear now as a dependency in the package.json? (managed by lerna)
There was a problem hiding this comment.
yeah I was curious on this as well?
| @@ -68,7 +68,7 @@ | |||
| "types": "./index.d.ts", | |||
| "dependencies": { | |||
| "buffer": "4.9.2", | |||
| "crypto-js": "^3.3.0", | |||
| "crypto-js": "^4.0.0", | |||
There was a problem hiding this comment.
In the version 3 PR, is does not have a ^ do we want to remove the ^ here?
There was a problem hiding this comment.
No, that was a fat finger in 3. I'm updating it
Codecov Report
@@ Coverage Diff @@
## main #8273 +/- ##
=======================================
Coverage 77.87% 77.87%
=======================================
Files 236 236
Lines 16513 16514 +1
Branches 3539 3539
=======================================
+ Hits 12859 12860 +1
Misses 3543 3543
Partials 111 111
Continue to review full report at Codecov.
|
|
This pull request has been automatically locked since there hasn't been any recent activity after it was closed. Please open a new issue for related bugs. Looking for a help forum? We recommend joining the Amplify Community Discord server |
Description of changes
WordArray.randomfor RN since it doesn't support latest CryptoJSIssue #, if available
#8256
Description of how you validated changes
Checklist
yarn testpassesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.