-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new integ test for amazon-cognito-identity-js to CCI jobs #8233
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 👍🏻
Codecov Report
@@ Coverage Diff @@
## main #8233 +/- ##
==========================================
- Coverage 77.74% 77.66% -0.09%
==========================================
Files 233 236 +3
Lines 16282 16504 +222
Branches 3474 3535 +61
==========================================
+ Hits 12659 12818 +159
- Misses 3516 3575 +59
- Partials 107 111 +4
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
This pull request has been automatically locked since there hasn't been any recent activity after it was closed. Please open a new issue for related bugs. Looking for a help forum? We recommend joining the Amplify Community Discord server |
The "old"
amazon-cognito-identity-js
integ test is now calledamazon-cognito-identity-js-cookie-storage
and the "new"amazon-cognito-identity-js
is added (though it appears like it was already in theconfig.yml
).Passing CCI build - https://app.circleci.com/pipelines/github/aws-amplify/amplify-js?branch=amazon-cognito-identity-js-integ-cci
yarn test
passesBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.