Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new integ test for amazon-cognito-identity-js to CCI jobs #8233

Merged
merged 6 commits into from
May 7, 2021

Conversation

nickarocho
Copy link
Contributor

The "old" amazon-cognito-identity-js integ test is now called amazon-cognito-identity-js-cookie-storage and the "new" amazon-cognito-identity-js is added (though it appears like it was already in the config.yml).

Passing CCI build - https://app.circleci.com/pipelines/github/aws-amplify/amplify-js?branch=amazon-cognito-identity-js-integ-cci

  • PR description included
  • yarn test passes
  • Tests are changed or added
  • Relevant documentation is changed or added (and PR referenced)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@nickarocho nickarocho requested review from amhinson and iartemiev May 6, 2021 18:32
Copy link
Member

@iartemiev iartemiev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍🏻

.circleci/config.yml Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented May 6, 2021

Codecov Report

Merging #8233 (a0be022) into main (9883974) will decrease coverage by 0.08%.
The diff coverage is 62.29%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #8233      +/-   ##
==========================================
- Coverage   77.74%   77.66%   -0.09%     
==========================================
  Files         233      236       +3     
  Lines       16282    16504     +222     
  Branches     3474     3535      +61     
==========================================
+ Hits        12659    12818     +159     
- Misses       3516     3575      +59     
- Partials      107      111       +4     
Impacted Files Coverage Δ
packages/datastore/src/sync/index.ts 13.35% <0.00%> (-0.05%) ⬇️
...pubsub/src/Providers/AWSAppSyncRealTimeProvider.ts 18.07% <0.00%> (-0.16%) ⬇️
...ages/datastore/src/sync/processors/subscription.ts 34.92% <10.38%> (-4.09%) ⬇️
packages/datastore/src/sync/processors/sync.ts 41.02% <44.44%> (-0.06%) ⬇️
packages/datastore/src/datastore/datastore.ts 79.67% <60.00%> (-0.56%) ⬇️
packages/datastore/src/sync/processors/mutation.ts 63.04% <73.91%> (+0.61%) ⬆️
...astore/src/authModeStrategies/multiAuthStrategy.ts 91.52% <91.52%> (ø)
packages/datastore/src/sync/utils.ts 88.93% <92.10%> (+0.53%) ⬆️
packages/api-graphql/src/GraphQLAPI.ts 87.95% <94.11%> (+0.22%) ⬆️
packages/api-graphql/src/index.ts 100.00% <100.00%> (ø)
... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7cc1fd0...a0be022. Read the comment docs.

Copy link
Contributor

@amhinson amhinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@github-actions
Copy link

github-actions bot commented May 7, 2022

This pull request has been automatically locked since there hasn't been any recent activity after it was closed. Please open a new issue for related bugs.

Looking for a help forum? We recommend joining the Amplify Community Discord server *-help channels or Discussions for those types of questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 7, 2022
@jimblanc jimblanc deleted the amazon-cognito-identity-js-integ-cci branch November 23, 2022 15:59
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants