-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Downsizing sample for some language in speech to text #7835
Conversation
Forget your password? the text has a typo
Codecov Report
@@ Coverage Diff @@
## main #7835 +/- ##
==========================================
+ Coverage 75.41% 75.66% +0.24%
==========================================
Files 215 215
Lines 13544 13550 +6
Branches 2671 2674 +3
==========================================
+ Hits 10214 10252 +38
+ Misses 3127 3095 -32
Partials 203 203
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@SebSchwartz, thanks a lot for this PR and even writing a missed unit test! Got one problem with downsampling that we want to address, but the rest LGTM 👍
packages/predictions/src/Providers/AmazonAIConvertPredictionsProvider.ts
Outdated
Show resolved
Hide resolved
packages/predictions/__tests__/Providers/AWSAIConvertPredictionsProvider-unit-test.ts
Show resolved
Hide resolved
packages/predictions/__tests__/Providers/AWSAIConvertPredictionsProvider-unit-test.ts
Outdated
Show resolved
Hide resolved
@wlee221 I've changed according to your comments ;) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This LGTM, thanks a lot for your contribution! Have you tried this change on your app?
Since the fix is straightforward and unit test has been included, I'll go ahead and merge this. Will do simple manual testing after this hits unstable. |
Codecov Report
@@ Coverage Diff @@
## main #7835 +/- ##
==========================================
+ Coverage 77.65% 77.87% +0.21%
==========================================
Files 236 236
Lines 16505 16513 +8
Branches 3535 3539 +4
==========================================
+ Hits 12817 12859 +42
+ Misses 3577 3543 -34
Partials 111 111
Continue to review full report at Codecov.
|
This pull request has been automatically locked since there hasn't been any recent activity after it was closed. Please open a new issue for related bugs. Looking for a help forum? We recommend joining the Amplify Community Discord server |
Issue #, if available: #7808
Description of changes:
If language is one of (fr-FR, en-AU, en-GB and fr-CA), downsize the sample to 8kHz and change url to transcribe.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.