Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Downsizing sample for some language in speech to text #7835

Merged
merged 11 commits into from
May 12, 2021

Conversation

SebSchwartz
Copy link
Contributor

Issue #, if available: #7808

Description of changes:

If language is one of (fr-FR, en-AU, en-GB and fr-CA), downsize the sample to 8kHz and change url to transcribe.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@codecov
Copy link

codecov bot commented Feb 28, 2021

Codecov Report

Merging #7835 (18e84d5) into main (7b478a5) will increase coverage by 0.24%.
The diff coverage is 86.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #7835      +/-   ##
==========================================
+ Coverage   75.41%   75.66%   +0.24%     
==========================================
  Files         215      215              
  Lines       13544    13550       +6     
  Branches     2671     2674       +3     
==========================================
+ Hits        10214    10252      +38     
+ Misses       3127     3095      -32     
  Partials      203      203              
Impacted Files Coverage Δ
...rc/Providers/AmazonAIConvertPredictionsProvider.ts 79.78% <86.66%> (+18.76%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7b478a5...18e84d5. Read the comment docs.

Copy link
Contributor

@wlee221 wlee221 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SebSchwartz, thanks a lot for this PR and even writing a missed unit test! Got one problem with downsampling that we want to address, but the rest LGTM 👍

@SebSchwartz SebSchwartz requested a review from wlee221 March 24, 2021 23:19
@SebSchwartz
Copy link
Contributor Author

@wlee221 I've changed according to your comments ;)

Copy link
Contributor

@wlee221 wlee221 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM, thanks a lot for your contribution! Have you tried this change on your app?

@wlee221
Copy link
Contributor

wlee221 commented May 12, 2021

Since the fix is straightforward and unit test has been included, I'll go ahead and merge this. Will do simple manual testing after this hits unstable.

@codecov-commenter
Copy link

Codecov Report

Merging #7835 (a89cfee) into main (c48ad83) will increase coverage by 0.21%.
The diff coverage is 88.23%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #7835      +/-   ##
==========================================
+ Coverage   77.65%   77.87%   +0.21%     
==========================================
  Files         236      236              
  Lines       16505    16513       +8     
  Branches     3535     3539       +4     
==========================================
+ Hits        12817    12859      +42     
+ Misses       3577     3543      -34     
  Partials      111      111              
Impacted Files Coverage Δ
...rc/Providers/AmazonAIConvertPredictionsProvider.ts 83.15% <88.23%> (+18.32%) ⬆️
...kages/amazon-cognito-identity-js/src/BigInteger.js 89.71% <0.00%> (+0.40%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c48ad83...a89cfee. Read the comment docs.

@github-actions
Copy link

This pull request has been automatically locked since there hasn't been any recent activity after it was closed. Please open a new issue for related bugs.

Looking for a help forum? We recommend joining the Amplify Community Discord server *-help channels or Discussions for those types of questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 13, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants