Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing return in AmazonAIConvertPredictionsProvider.ts #7803

Merged
merged 2 commits into from
Mar 1, 2021
Merged

Missing return in AmazonAIConvertPredictionsProvider.ts #7803

merged 2 commits into from
Mar 1, 2021

Conversation

SebSchwartz
Copy link
Contributor

Without this return, user will also get 'Source types other than byte source are not supported.' error.

Issue #, if available:

Description of changes:
Dont reject with another error as well.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Without this return, user will also get 'Source types other than byte source are not supported.' error.
@codecov
Copy link

codecov bot commented Feb 22, 2021

Codecov Report

Merging #7803 (d45ddfc) into main (d32be03) will not change coverage.
The diff coverage is 50.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #7803   +/-   ##
=======================================
  Coverage   74.13%   74.13%           
=======================================
  Files         215      215           
  Lines       13450    13450           
  Branches     2641     2641           
=======================================
  Hits         9971     9971           
  Misses       3280     3280           
  Partials      199      199           
Impacted Files Coverage Δ
...rc/Providers/AmazonAIConvertPredictionsProvider.ts 61.01% <0.00%> (ø)
packages/core/src/Platform/version.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 98f7faf...d45ddfc. Read the comment docs.

Copy link
Contributor

@wlee221 wlee221 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM, thanks for the catch.

@wlee221 wlee221 merged commit ad2dd86 into aws-amplify:main Mar 1, 2021
@github-actions
Copy link

github-actions bot commented Mar 2, 2022

This pull request has been automatically locked since there hasn't been any recent activity after it was closed. Please open a new issue for related bugs.

Looking for a help forum? We recommend joining the Amplify Community Discord server *-help channels or Discussions for those types of questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 2, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants