Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: rewrite "forget password" to "forgot password" #7009

Merged
merged 5 commits into from
Oct 22, 2020
Merged

Conversation

wlee221
Copy link
Contributor

@wlee221 wlee221 commented Oct 20, 2020

Issue #, if available: #6921, #7008.

Description of changes: rewrite "forget password" to "forgot password". This is a follow up to #7008 and #6921.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@wlee221 wlee221 requested a review from Ashish-Nanda as a code owner October 20, 2020 01:45
@wlee221 wlee221 requested a review from elorzafe October 20, 2020 01:45
@codecov
Copy link

codecov bot commented Oct 20, 2020

Codecov Report

Merging #7009 into main will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #7009   +/-   ##
=======================================
  Coverage   73.27%   73.27%           
=======================================
  Files         213      213           
  Lines       13195    13195           
  Branches     2488     2584   +96     
=======================================
  Hits         9669     9669           
+ Misses       3362     3332   -30     
- Partials      164      194   +30     
Impacted Files Coverage Δ
...mplify-vue/src/components/authenticator/SignIn.vue 37.20% <ø> (ø)
packages/aws-amplify-react/src/Auth/SignIn.tsx 83.33% <100.00%> (ø)
packages/auth/src/OAuth/OAuth.ts 56.11% <0.00%> (ø)
packages/core/src/Credentials.ts 31.51% <0.00%> (ø)
packages/analytics/src/Analytics.ts 63.58% <0.00%> (ø)
packages/datastore/src/sync/index.ts 15.41% <0.00%> (ø)
packages/datastore/src/sync/outbox.ts 24.00% <0.00%> (ø)
packages/datastore/src/storage/storage.ts 71.66% <0.00%> (ø)
packages/core/src/OAuthHelper/GoogleOAuth.ts 33.33% <0.00%> (ø)
packages/core/src/Util/Reachability.native.ts 37.50% <0.00%> (ø)
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 96fda2a...eadf1a4. Read the comment docs.

Copy link
Contributor

@Ashish-Nanda Ashish-Nanda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

Copy link
Contributor

@sammartinez sammartinez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🌮

@amhinson
Copy link
Contributor

The only other thing I'd consider here is customers with their own language customizations (https://docs.amplify.aws/ui/customization/translations/q/framework/react), as this wouldn't show the correct translation without updating their code.

@wlee221
Copy link
Contributor Author

wlee221 commented Oct 21, 2020

@amhinson, that is a good point. Because this is a deprecating component, we may want to just leave it as-is. What do you think @sammartinez?

@sammartinez
Copy link
Contributor

@amhinson, that is a good point. Because this is a deprecating component, we may want to just leave it as-is. What do you think @sammartinez?

I believe we can do this fix as this would be a patch for customers utilizing this component. I am OK with this change going in but to @amhinson, customers will need to upgrade their code.

@sammartinez sammartinez merged commit fd989e4 into main Oct 22, 2020
@wlee221 wlee221 deleted the fix-auth-typo branch November 18, 2020 19:53
CryogenicPlanet pushed a commit to MLH-Fellowship/amplify-js that referenced this pull request Jan 20, 2021
* fix: fix typo in SignIn.vue (aws-amplify#6921)

Forget your password? the text has a typo

* Rewrite "forget password" to "forgot password"

Co-authored-by: sksabircn <[email protected]>
Co-authored-by: Alex Hinson <[email protected]>
@github-actions
Copy link

This pull request has been automatically locked since there hasn't been any recent activity after it was closed. Please open a new issue for related bugs.

Looking for a help forum? We recommend joining the Amplify Community Discord server *-help channels or Discussions for those types of questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants