-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: rewrite "forget password" to "forgot password" #7009
Conversation
Forget your password? the text has a typo
Codecov Report
@@ Coverage Diff @@
## main #7009 +/- ##
=======================================
Coverage 73.27% 73.27%
=======================================
Files 213 213
Lines 13195 13195
Branches 2488 2584 +96
=======================================
Hits 9669 9669
+ Misses 3362 3332 -30
- Partials 164 194 +30
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🌮
The only other thing I'd consider here is customers with their own language customizations (https://docs.amplify.aws/ui/customization/translations/q/framework/react), as this wouldn't show the correct translation without updating their code. |
@amhinson, that is a good point. Because this is a deprecating component, we may want to just leave it as-is. What do you think @sammartinez? |
I believe we can do this fix as this would be a patch for customers utilizing this component. I am OK with this change going in but to @amhinson, customers will need to upgrade their code. |
* fix: fix typo in SignIn.vue (aws-amplify#6921) Forget your password? the text has a typo * Rewrite "forget password" to "forgot password" Co-authored-by: sksabircn <[email protected]> Co-authored-by: Alex Hinson <[email protected]>
This pull request has been automatically locked since there hasn't been any recent activity after it was closed. Please open a new issue for related bugs. Looking for a help forum? We recommend joining the Amplify Community Discord server |
Issue #, if available: #6921, #7008.
Description of changes: rewrite "forget password" to "forgot password". This is a follow up to #7008 and #6921.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.