-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cognito hosted ui #585
Cognito hosted ui #585
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Update withCognito -> withHostedCognito
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Codecov Report
@@ Coverage Diff @@
## master #585 +/- ##
==========================================
+ Coverage 86.93% 87.17% +0.24%
==========================================
Files 71 72 +1
Lines 3345 3424 +79
Branches 634 648 +14
==========================================
+ Hits 2908 2985 +77
- Misses 420 422 +2
Partials 17 17
Continue to review full report at Codecov.
|
Please note that the name for the HOC is changed withHostedCognito -> withHostedAuthenticator
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please note the change;
withHostedCognito -> withHostedAuthenticator
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
I am glad to see this in a release, but surprised that the release minor number didn't bump for a feature add. |
hello @mlabieniec / @powerful23 Do you know if the method Auth.federatedSignIn() creates a facebook user in cognito user pool? |
@lucaslc-sp no you need to follow this doc, basically |
@powerful23 Thank you! If you allow me, one more question: what i have to put in redirect_url parameter to return to my react native app? |
@lucaslc-sp you would need to add a deep link for your app based on your platform: |
@mlabieniec Thank you! |
@powerful23 , In reference to @lucaslc-sp's question, do you know if there is a way to create a facebook user in cognito user pool? I have enabled Google and Facebook login on my user pool, and I have user pool groups for both types of users, but if what you say is true, what is the purpose of either of those groups? I am using a custom login UI that is totally separate from the Hosted Login UI, if that makes a difference. |
@reggie3 In my experience, the only way to get a federated login to create a UP entry is to use hosted UI. |
@reggie3 as I know for now the only way to make federated users sign into Cognito User Pool is to use the Hosted UI feature. @yuntuowang do you know if there is any way to use custom login UI to implement this? |
@powerful23 did you find any solution for this? |
This pull request has been automatically locked since there hasn't been any recent activity after it was closed. Please open a new issue for related bugs. Looking for a help forum? We recommend joining the Amplify Community Discord server |
Issue #, if available:
Fixes #565 #480 #311 #45 #542 #376
Description of changes:
Integrate Cognito hosted ui into aws-amplify
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.