feat(data): events client #13923
feat(data): events client #13923
Conversation
iartemiev
requested review from
haverchuck,
cshfang,
jimblanc,
HuiSF and
a team
as code owners
iartemiev
force-pushed
the
feat/events/main
branch
from
ab6e471 to
a245ec4
Compare
|
Please ensure that this PR:
A repository administrator is required to review this change. |
| @@ -1181,7 +1181,7 @@ describe('AWSAppSyncRealTimeProvider', () => { | |||
| }); | |||
|
|
|||
| test('authenticating with AWS_LAMBDA/custom w/ custom header function that accepts request options', async () => { | |||
| expect.assertions(2); | |||
| expect.assertions(3); | |||
There was a problem hiding this comment.
This test asserts on the number of times the additionalHeaders function gets executed. Since we split out WS connect into its own method, additionalHeaders gets evaluated one more time in this test, but resolves to the same value. It's a no-op in terms of behavior.
| @@ -677,7 +675,9 @@ describe('AWSAppSyncRealTimeProvider', () => { | |||
| }), | |||
| ); | |||
|
|
|||
| expect(socketCloseSpy).toHaveBeenNthCalledWith(1, 3001); | |||
| await delay(1); | |||
There was a problem hiding this comment.
Seeing an occasional race condition here without the tick delay. Test is unchanged otherwise.
| }; | ||
| } | ||
|
|
||
| export abstract class AWSWebSocketProvider { |
There was a problem hiding this comment.
This class is functionally identical to AWSAppSyncRealTimeProvider in main. Methods that deal with AppSync vs Events specifics were converted to abstract and each respective provider implements those. Some of the larger methods were split up for legibility as well.
Note: these are just expected bundle size value updates. No dependencies or versions were changed in this PR. |
| @@ -12,6 +12,7 @@ import { | |||
| import { ConnectionState as CS } from '../src/types/PubSub'; | |||
|
|
|||
| import { AWSAppSyncRealTimeProvider } from '../src/Providers/AWSAppSyncRealTimeProvider'; | |||
| import { isCustomDomain } from '../src/Providers/AWSWebSocketProvider/appsyncUrl'; | |||
There was a problem hiding this comment.
isCustomDomain used to be a private method on AWSAppSyncRealTimeProvider but we moved it out into a util.
iartemiev
force-pushed
the
feat/events/main
branch
from
cca4816 to
538dd9f
Compare
| @@ -223,6 +224,28 @@ function parseData( | |||
| }; | |||
| } | |||
|
|
|||
| function parseCustom( | |||
There was a problem hiding this comment.
nit: should we add unit tests for this new parse function?
There was a problem hiding this comment.
Good call. It's tested indirectly as part of this describe block: https://github.com/aws-amplify/amplify-js/pull/13923/files#diff-d114e2967bd860edbf0a234243cc226fe3f6215597d5392dc7b4c276b6e8eaafR47
But I'll follow up with a couple more in a separate PR.
There was a problem hiding this comment.
Description of changes
Adds events client
Description of how you validated changes
Checklist
yarn testpassesChecklist for repo maintainers
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.