fix(core): check storage availability for localStorage and sessionStorage #13898
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
plevavas
requested review from
haverchuck,
cshfang,
jimblanc and
HuiSF
as code owners
plevavas
force-pushed
the
fix/storage-availability
branch
2 times, most recently
from
b79358c
to
d23319c
Compare
plevavas
force-pushed
the
fix/storage-availability
branch
from
d23319c
to
193a988
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
This PR introduces the storageAvailable function (based on MDN documentation) to check the availability of localStorage and sessionStorage. If unavailable (e.g., Safari private mode or quota issues), it falls back to InMemoryStorage instead of throwing a SecurityError exception.
Description of how you validated changes
Checklist
yarn testpassesChecklist for repo maintainers
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.