chore: upgrade eslint and relevant dependencies #13891
Conversation
HuiSF
requested review from
haverchuck,
cshfang,
jimblanc and
a team
as code owners
| varsIgnorePattern: '^_', | ||
| args: 'after-used', | ||
| argsIgnorePattern: '^_', | ||
| caughtErrors: 'none', |
There was a problem hiding this comment.
caughtErrors: 'none', is required by the new version for unused catch (error) in the codebase
There was a problem hiding this comment.
why would we catch error but not use it? Maybe we should adhere to default here?
There was a problem hiding this comment.
If we decided to do so, I want to change the rule separately, wanted to keep this PR only the migration scope.
| allowShortCircuit: true, | ||
| allowTernary: true, |
There was a problem hiding this comment.
Allow code patterns used in the codebase, such as
isBrowser() && doBrowserStuff()
runA ? a() : b()
Question: should we disallow this, as the suggestion makes sense.
There was a problem hiding this comment.
i do feel this allows for easy shorthand. I feel nothing wrong in doing this 😅
|
|
||
| '@typescript-eslint/no-useless-constructor': 'error', | ||
| '@typescript-eslint/no-require-imports': 'off', | ||
|
|
There was a problem hiding this comment.
New version disallows using require() by default, we are using it in test codebase for module loading and mocking, as well as in the react-native for module resolution at runtime.
Description of changes
Upgrade eslint to the latest version, v8 is EOL on 10/05.
eslint.config.mjsis generated by eslint provided migration toolnpx @eslint/migrate-config .eslintrc.jswith some necessary manual fixes for backwards compatibility@typescript/eslint-pluginrule deprecations)Issue #, if available
Description of how you validated changes
yarn build && yarn lint && yarn testChecklist
yarn testpassesChecklist for repo maintainers
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.