Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(auth): [EMAIL MFA] enable integ tests with backend configuration swapping #13794

Merged
merged 2 commits into from
Sep 23, 2024

Conversation

jjarvisp
Copy link
Member

@jjarvisp jjarvisp commented Sep 9, 2024

Description of changes

The purpose of this pull request is to enable E2E tests for the Email MFA feature as well as introduce a mechanism to allow the test definition to specify which backend configuration the underlying application should use.

Issue #, if available

Description of how you validated changes

Test Run: https://github.com/jjarvisp/amplify-js/actions/runs/10856005455

Checklist

  • PR description included
  • yarn test passes
  • Unit Tests are changed or added
  • Relevant documentation is changed or added (and PR referenced)

Checklist for repo maintainers

  • Verify E2E tests for existing workflows are working as expected or add E2E tests for newly added workflows
  • New source file paths included in this PR have been added to CODEOWNERS, if appropriate

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jjarvisp jjarvisp marked this pull request as ready for review September 9, 2024 18:29
@jjarvisp jjarvisp requested a review from a team as a code owner September 9, 2024 18:29
@jjarvisp jjarvisp changed the title feat(auth): [EMAIL MFA] enable e2e tests with backend configuration swapping feat(auth): [EMAIL MFA] enable integ tests with backend configuration swapping Sep 10, 2024
Copy link
Member

@israx israx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jjarvisp jjarvisp merged commit 6da0652 into aws-amplify:feat/email-mfa Sep 23, 2024
28 checks passed
jjarvisp added a commit that referenced this pull request Oct 31, 2024
* [Email MFA] Updating fetchMFAPreference and updateMFAPreference (#13720)

* add EMAIL MFA option in fetchMFAPreference

* add EMAIL MFA option in updateMFAPreference

* update fetchMFAPreference tests

* update updateMFAPreference tests

* update bundle size

* remove redundant assertions

* [Email MFA] Add support for EMAIL_OTP during sign in flows (#13745)

* Confirm Sign In With Email OTP

* Confirm Sign In Tests With Email OTP

* Update packages/auth/src/types/models.ts

Co-authored-by: israx <[email protected]>

* Fix Errant Pascal Casing

---------

Co-authored-by: israx <[email protected]>

* feat(auth): [EMAIL MFA] Sign In / Confirm Sign In With MFA_SETUP (#13760)

* Sign In / Confirm Sign In With MFA_SETUP

* Sign In State Management Tests

* Confirm Sign In Happy Path Tests

* Fix State Management Tests

* Apply Feedback

* loose email matching

* Remove Unnecessary Export

* Update SignInHelpers For Getting Allowed MFA Setup Types

* Add Error Case Unit Tests

* feat(auth): [EMAIL MFA] enable integ tests with backend configuration swapping (#13794)

* chore: enable mfa integ tests

* chore: add mfa-setup test def

* chore: temporarily enable push integ tests

* chore: disable push integ tests

* chore: address test strategy feedback

* chore: use trimmed challenge response

* chore: improved naming

* chore: update bundle size tests

* chore: remove trimmed challenge response

---------

Co-authored-by: israx <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants