Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(adapter-nextjs): add runtimeOptions.cookies to createServerRunner #13788

Merged
merged 4 commits into from
Dec 18, 2024
Merged

feat(adapter-nextjs): add runtimeOptions.cookies to createServerRunner #13788

merged 4 commits into from
Dec 18, 2024

Conversation

HuiSF
Copy link
Member

@HuiSF HuiSF commented Sep 6, 2024

Description of changes

Add runtimeOptions to the createServerRunner function. e.g.:

createServerRunner({
  config,
  runtimeOptions: {
    cookies: {
      domain: '.example.com',
      sameSite: 'strict',
    }
  }
})

Issue #, if available

Description of how you validated changes

  • unit tests
  • manual testing with a sample app

Checklist

  • PR description included
  • yarn test passes
  • Unit Tests are changed or added
  • Relevant documentation is changed or added (and PR referenced)

Checklist for repo maintainers

  • Verify E2E tests for existing workflows are working as expected or add E2E tests for newly added workflows
  • New source file paths included in this PR have been added to CODEOWNERS, if appropriate

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@HuiSF HuiSF force-pushed the hui/feat/adapter-nextjs/apply-cookie-attrs branch from b47d2f2 to 6cbdad1 Compare September 11, 2024 20:56
@HuiSF HuiSF force-pushed the hui/feat/adapter-nextjs/apply-cookie-attrs branch from 6cbdad1 to af39e86 Compare October 1, 2024 23:01
@HuiSF HuiSF changed the title feat(aws-amplify|adapter-nextjs): add runtimeOptions.cookies to createServerRunner feat(adapter-nextjs): add runtimeOptions.cookies to createServerRunner Oct 1, 2024
@HuiSF HuiSF force-pushed the hui/feat/adapter-nextjs/apply-cookie-attrs branch from af39e86 to fa5d86c Compare November 21, 2024 17:04
@HuiSF HuiSF requested a review from pranavosu as a code owner November 21, 2024 17:04
@HuiSF HuiSF requested a review from sktimalsina as a code owner December 18, 2024 18:08
@HuiSF HuiSF merged commit 08a3490 into feat/server-auth/main Dec 18, 2024
28 checks passed
@HuiSF HuiSF deleted the hui/feat/adapter-nextjs/apply-cookie-attrs branch December 18, 2024 19:39
HuiSF added a commit that referenced this pull request Jan 6, 2025
@HuiSF
feat(adapter-nextjs): add runtimeOptions.cookies to createServerRunner (
331bb05 
#13788)

* feat(aws-amplify|adapter-nextjs): add runtimeOptions.cookies to createServerRunner

* chore: resolve comments

* chore(adapter-nextjs): adapt the latest impl. changes
HuiSF added a commit that referenced this pull request Jan 9, 2025
@HuiSF
feat(adapter-nextjs): add runtimeOptions.cookies to createServerRunner (
2c3c107 
#13788)

* feat(aws-amplify|adapter-nextjs): add runtimeOptions.cookies to createServerRunner

* chore: resolve comments

* chore(adapter-nextjs): adapt the latest impl. changes
HuiSF added a commit that referenced this pull request Jan 27, 2025
@HuiSF
feat(adapter-nextjs): add runtimeOptions.cookies to createServerRunner (
903e512 
#13788)

* feat(aws-amplify|adapter-nextjs): add runtimeOptions.cookies to createServerRunner

* chore: resolve comments

* chore(adapter-nextjs): adapt the latest impl. changes
HuiSF added a commit that referenced this pull request Feb 11, 2025
@HuiSF
feat: support server-side auth flows with Cognito managed login (#14168)
825d338 
* feat(adapter-nextjs): add runtimeOptions.cookies to createServerRunner (#13788)

* feat(aws-amplify|adapter-nextjs): add runtimeOptions.cookies to createServerRunner

* chore: resolve comments

* chore(adapter-nextjs): adapt the latest impl. changes

* feat(adapter-nextjs): add createAuthRouteHandlers to createServerRunner (#13801)

* feat(aws-amplify|adapter-nextjs): add runtimeOptions.cookies to createServerRunner

* feat(adapter-nextjs): add createAuthRouteHandlers to createServerRunner

* chore(adapter-nextjs): resolve comments

* chore(adapter-nextjs): remove unnecessary check

* feat(adapter-nextjs): server-side auth flows integrating cognito hosted UI (#13827)

* chore(auth): export necessary utilities and types to support server-side auth

* chore(aws-amplify): export necessary utilities to support server-side auth

* feat(adapter-nextjs): server-side auth api route integrating cognito hosted ui

* chore(adapter-nextjs): resolve comments

* refactor(adapter-nextjs): remove redundant username fallback

* feat(adapter-nextjs): add user has signed in check before initiating sign-in and sign-up (#13839)

* feat(adapter-nextjs): add user has signed in check before initiating sign-in and sign-up

* chore(adapter-nextjs): rename hasUserSignedIn to hasActiveUserSession

* fix(adapter-nextjs): make createAuthRouteHandlers interface work in both App and Pages routers (#13840)

* feat(adapter-nextjs): set cookie secure: false with non-SSL domain (#13841)

* feat(adapter-nextjs): allow cookie secure: false with non-SSL domain

* fix(adapter-nextjs): wrong naming and impl. of isSSLOrigin

* chore(adapter-nextjs): resolve comment

* refactor(adapter-nextjs): use maxAge attribute to set cookie from server to avoid clock drift (#14103)

* fix(adapter-nextjs): wrong use of nullish coalescing (#14112)

* refactor(adapter-nextjs): remove redundant clockDrift cookie (#14114)

refactor(adapter-nextjs): remove redundant clockDrift cookie ⤵️

Reasons:
  1. token exachange is happening on a server - and production server rarely has wrong system time
  2. when setting token cookies from server, it uses Max-Age header which is relative to the client system time. Clock drift became irrelevant
  3. surely we can argue sever system time can go wrong too, however, a Next.js app API route can be executed on different servers (load balancing), there is no source of truth to generate a clock drift value

* chore: enable tag publishing for server-auth (#14115)

* fix(adapter-nextjs): wrong spot for checking app origin and auth config (#14119)

* fix(adapter-nextjs): not await params async API in Next.js 15 (#14125)

* feat(adapter-nextjs): surface redirect error and sign-in timeout error (#14116)

* feat(adapter-nextjs): surface redirect error and sign-in timeout error

* feat(adapter-nextjs): expose both error and errorDescription

* chore(adapter-nextjs): remove unnecessary undefined fallback

* chore(adapter-nextjs): add warning re: using http in production (#14134)

* fix(core): generateRandomString uses Math.random() (#14132)

* fix(core): generateRandomString uses Math.random()

* chore(core): use better test to test actual logic

* chore(aws-amplify/adapter-nextjs): remove extraneous deps (#14141)

* fix(adapter-nextjs): removing only tokens and LastAuthUser cookies (#14152)

* fix(adapter-nextjs): wrong cookie attributes get set sometimes (#14169)

* chore: add E2E tests for next.js server auth

* chore: disable tag release

* fix(aws-amplify|api): internals export paths
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cshfang cshfang cshfang approved these changes

@jjarvisp jjarvisp jjarvisp approved these changes

@haverchuck haverchuck Awaiting requested review from haverchuck

@pranavosu pranavosu Awaiting requested review from pranavosu pranavosu is a code owner

@sktimalsina sktimalsina Awaiting requested review from sktimalsina sktimalsina is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@HuiSF @cshfang @jjarvisp