Setting Store Tokens should only clear tokens that no longer have a value #13584
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…alue. This resolves thrashing events when a consumer is listening to storage events, preventing them from seeing a 'clear' followed immediatly by a 'set' value.
jon-armen
requested review from
ukhan-amazon,
haverchuck,
cshfang,
jimblanc and
HuiSF
as code owners
|
Hello, @jon-armen and thanks for taking the time to submit this PR! We'll get this reviewed by the team internally and follow up with any questions or feedback that we have. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Setting Store Tokens should only clear tokens that no longer have a value. This resolves thrashing events when a consumer is listening to storage events, preventing them from seeing a 'clear' followed immediately by a 'set' value.
Issue #, if available
#13583
Checklist
yarn testpassesChecklist for repo maintainers
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.