fix(deps): fix more implicit deps and add linting (#14137)

Co-authored-by: ashika112 <[email protected]> Co-authored-by: ashika112 <[email protected]>
aws-amplify · Jan 28, 2025 · 22ca811 · 22ca811
1 parent 8b489d1
commit 22ca811
Show file tree

Hide file tree

Showing 9 changed files with 30 additions and 2 deletions.
diff --git a/eslint.config.mjs b/eslint.config.mjs
@@ -24,7 +24,7 @@ const compat = new FlatCompat({
 const customClientDtsFiles = customClientDtsBundlerConfig.entries
 	.map(clientBundlerConfig => clientBundlerConfig.outFile)
 	.filter(outFile => outFile?.length > 0)
-	.map(outFile => outFile.replace(__dirname + path.sep, '')) // Convert absolute path to relative path
+	.map(outFile => outFile.replace(__dirname + path.sep, '')); // Convert absolute path to relative path
 
 export default [
 	{
@@ -294,4 +294,15 @@ export default [
 			'jsdoc/no-undefined-types': 1,
 		},
 	},
+	{
+		ignores: [
+			'**/**.{native,android,ios}.**',
+			'**/__tests__/**',
+			'**/packages/adapter-nextjs/**',
+			'**/packages/react-native/example/**',
+		],
+		rules: {
+			'import/no-extraneous-dependencies': 'error',
+		},
+	},
 ];
diff --git a/packages/api-rest/package.json b/packages/api-rest/package.json
@@ -89,6 +89,7 @@
 	"devDependencies": {
 		"@aws-amplify/core": "6.9.2",
 		"@aws-amplify/react-native": "1.1.6",
+		"@aws-sdk/types": "3.387.0",
 		"typescript": "5.0.2"
 	},
 	"size-limit": [

diff --git a/packages/api/package.json b/packages/api/package.json
@@ -68,6 +68,7 @@
 	},
 	"homepage": "https://aws-amplify.github.io/",
 	"devDependencies": {
+		"@aws-amplify/core": "6.9.2",
 		"jest-fetch-mock": "3.0.3",
 		"typescript": "5.0.2"
 	},
@@ -82,6 +83,11 @@
 	"dependencies": {
 		"@aws-amplify/api-graphql": "4.7.2",
 		"@aws-amplify/api-rest": "4.0.67",
+		"@aws-amplify/data-schema": "^1.7.0",
+		"rxjs": "^7.8.1",
 		"tslib": "^2.5.0"
+	},
+	"peerDependencies": {
+		"@aws-amplify/core": "^6.1.0"
 	}
 }
diff --git a/packages/core/package.json b/packages/core/package.json
@@ -54,6 +54,7 @@
 		"@aws-sdk/types": "3.398.0",
 		"@smithy/util-hex-encoding": "2.0.0",
 		"@types/uuid": "^9.0.0",
+		"cookie": "^0.7.0",
 		"js-cookie": "^3.0.5",
 		"rxjs": "^7.8.1",
 		"tslib": "^2.5.0",

diff --git a/packages/datastore/package.json b/packages/datastore/package.json
@@ -45,6 +45,7 @@
 	],
 	"dependencies": {
 		"@aws-amplify/api": "6.2.2",
+		"@aws-amplify/api-graphql": "4.7.2",
 		"buffer": "4.9.2",
 		"idb": "5.0.6",
 		"immer": "9.0.6",

diff --git a/packages/geo/package.json b/packages/geo/package.json
@@ -69,6 +69,7 @@
 	"dependencies": {
 		"@aws-sdk/client-location": "3.621.0",
 		"@turf/boolean-clockwise": "6.5.0",
+		"@aws-sdk/types": "3.398.0",
 		"camelcase-keys": "6.2.2",
 		"tslib": "^2.5.0"
 	},

diff --git a/packages/notifications/package.json b/packages/notifications/package.json
@@ -91,6 +91,7 @@
 		"push-notifications"
 	],
 	"dependencies": {
+		"@aws-sdk/types": "3.398.0",
 		"lodash": "^4.17.21",
 		"tslib": "^2.5.0"
 	},

diff --git a/packages/rtn-push-notification/package.json b/packages/rtn-push-notification/package.json
@@ -23,10 +23,17 @@
 		"lint:fix": "eslint '**/*.{ts,tsx}' --fix",
 		"ts-coverage": "typescript-coverage-report -p ./tsconfig.build.json -t 99"
 	},
+	"dependencies": {
+		"lodash": "^4.17.21"
+	},
 	"devDependencies": {
 		"@types/react-native": "0.70.0",
+		"react-native": "0.71.0",
 		"typescript": "5.0.2"
 	},
+	"peerDependencies": {
+		"react-native": ">=0.70"
+	},
 	"repository": {
 		"type": "git",
 		"url": "https://github.com/aws-amplify/amplify-js.git"

diff --git a/packages/storage/__tests__/providers/s3/apis/internal/testUtils.ts b/packages/storage/__tests__/providers/s3/apis/internal/testUtils.ts
@@ -1,5 +1,4 @@
 import { AWSCredentials } from '@aws-amplify/core/internals/utils';
-import { expect } from '@jest/globals';
 import { type MatcherFunction } from 'expect';
 
 const toBeLastCalledWithConfigAndInput: MatcherFunction<