Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: node compatibility test #1416

Merged
merged 6 commits into from
May 6, 2024
Merged

feat: node compatibility test #1416

merged 6 commits into from
May 6, 2024

Conversation

bombguy
Copy link
Contributor

@bombguy bombguy commented May 1, 2024

Problem

We should be ensuring that our repo is able to install, build, and test using the specified node versions.

Issue number, if available:

Changes

  • Update setup_node action to take in node-version input
  • Add node versions to test matrix in following jobs: install, build, test_with_coverage
  • Add node versions to test matrix for e2e_deployment, e2e_create_amplify
  • Skip global.crypto workaround for node > 20 as it is no longer needed.

Corresponding docs PR, if applicable:

Validation

Checklist

  • If this PR includes a functional change to the runtime behavior of the code, I have added or updated automated test coverage for this change.
  • If this PR requires a change to the Project Architecture README, I have included that update in this PR.
  • If this PR requires a docs update, I have linked to that docs PR above.
  • If this PR modifies E2E tests, makes changes to resource provisioning, or makes SDK calls, I have run the PR checks with the run-e2e label set.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link

changeset-bot bot commented May 1, 2024

🦋 Changeset detected

Latest commit: be16ddb

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@aws-amplify/integration-tests Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@bombguy bombguy marked this pull request as ready for review May 1, 2024 09:51
@bombguy bombguy added the run-e2e Label that will include e2e tests in PR checks workflow label May 1, 2024
Copy link
Member

@sobolk sobolk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

sobolk
sobolk previously approved these changes May 6, 2024
@bombguy
Copy link
Contributor Author

bombguy commented May 6, 2024

The checks need to be updated with the new names that includes the matrix configurations post merge

@bombguy bombguy enabled auto-merge (squash) May 6, 2024 21:40
@bombguy bombguy merged commit a723bf4 into main May 6, 2024
50 checks passed
@bombguy bombguy deleted the node-compatibility branch May 6, 2024 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
run-e2e Label that will include e2e tests in PR checks workflow
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants