Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finish implementation of ancient PR message #95

Merged
merged 4 commits into from
Sep 21, 2021
Merged

Finish implementation of ancient PR message #95

merged 4 commits into from
Sep 21, 2021

Conversation

Plabick
Copy link
Contributor

@Plabick Plabick commented Jun 14, 2021

Issue #, if available:
#19
Description of changes:

  • Added an ancient PR message input. Someone seems to have started implementing it, I picked up where they left off.
  • Made minor changes to example workflow in the readme, for clarity

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@Plabick Plabick changed the title Finish Implementation of Ancient PR label Finish implementation of ancient PR message Jun 14, 2021
@kellertk
Copy link
Contributor

kellertk commented Aug 19, 2021

@Plabick thank you very much for your contribution! This repository requires that all commits be signed before merging. Can you please resubmit with a signed commit?

@Plabick
Copy link
Contributor Author

Plabick commented Aug 19, 2021

@kellertk I just signed all the commits using git rebase - did that satisfy the requirement?

@Plabick Plabick requested a review from kellertk August 19, 2021 19:52
Plabick and others added 3 commits August 19, 2021 20:39
Signed-off-by: Peter Labick <[email protected]>
Bumps [eslint](https://github.com/eslint/eslint) from 7.16.0 to 7.32.0.
- [Release notes](https://github.com/eslint/eslint/releases)
- [Changelog](https://github.com/eslint/eslint/blob/master/CHANGELOG.md)
- [Commits](eslint/eslint@v7.16.0...v7.32.0)

---
updated-dependencies:
- dependency-name: eslint
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
@Plabick
Copy link
Contributor Author

Plabick commented Aug 20, 2021

@kellertk Sorry for the mixup - my last commits were signed but not verified. That is fixed now, everything should be good to go. By the way, thanks for making this action - my organization has been using it on internal repos and its been very helpful.

@kellertk kellertk closed this Sep 21, 2021
@kellertk kellertk reopened this Sep 21, 2021
@kellertk kellertk merged commit 57e400a into aws-actions:main Sep 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants