-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Return secrets as outputs instead of values #36
base: main
Are you sure you want to change the base?
Conversation
(no longer needed)
@ecraw-amzn Is there something I still need to do before this PR can be reviewed and merged? |
@jbct can we merge this. |
Is there anything holding this feature up? |
Bump We've encountered this issue again. What is the status of the PR? |
Since it has been left unresolved for over a year now, some conflicts have mounted up. I don't know if I'll get around to fixing it anytime soon, though I imagine the conflict can't be too difficult to manage. |
Issue #14: Environment variables vs outputs
Description of changes:
Secrets are now returned as action outputs. This results in the following improvements:
README.md, action.yml and code comments have been updated accordingly. Tests are passing.
If you prefer reviewing less files and compiling the source code yourselves, I have created a parallel PR(#37) containing only the code changes without the built
dist
files.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.