Added support to configure proxy #15
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonmarty
requested changes
Apr 27, 2023
| import { | ||
| GetSecretValueCommand, ListSecretsCommand, |
There was a problem hiding this comment.
Could you update your tab size to 4 spaces and resubmit?
action.yml
Outdated
| required: true | ||
| parse-json-secrets: | ||
| description: '(Optional) If true, JSON secrets will be deserialized, creating a secret environment variable for each key-value pair.' | ||
| description: "(Optional) If true, JSON secrets will be deserialized, creating a secret environment variable for each key-value pair." |
There was a problem hiding this comment.
Idem here, is there a mismatch between existing code and ESLint rules? Otherwise revert these formatting changes.
|
Any idea when this PR will be merged ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
*Issue #12
Description of changes:
If the runners are running inside a secure environment, to run this action they would need to provide proxy settings to connect with AWS. So, have added support for it. Users can either add the proxy variable as input or as an env
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.