New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refine builder #1

Merged

awran5 merged 2 commits into awran5:main from baurine:refine_builder

Dec 3, 2021

Contributor

baurine commented Dec 3, 2021 •

edited

Loading

hi @awran5 , thanks for your template, I used it in my project, and I found we can do some refinement for it so I submit this PR.

What did:

Change the output dir to dist instead of public to avoid version control conflicts.
Unify the dev and production builder
add { ignoreInitial: true } for watch() to avoid meaningless rebuild at the first time, without this option, it rebuilds tons of times and is very slow to show the first page for the large project.
watch all files include .css, not just .ts/.tsx.

I think this PR should apply to esbuild-react-app-js-template as well if this PR is merged.

baurine added 2 commits

December 3, 2021 17:48


          refine builder

be786b7


          watch all files not just ts

a18bce8

baurine mentioned this pull request

Build the frontend by esbuild instead of webpack pingcap/tidb-dashboard#1063

Merged

awran5 merged commit 56f3c78 into awran5:main

Owner

awran5 commented Dec 3, 2021

@baurine Nice add .. Thank you very mush!

baurine deleted the refine_builder branch

December 5, 2021 08:10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet