Added port to webhook-service, generated bundle with v1.0.1 #1
Conversation
Signed-off-by: Juraci Paixão Kröhling <[email protected]>
| containerPort: 443 | ||
| targetPort: 4343 | ||
| deploymentName: webhook-operator-webhook | ||
| - admissionReviewVersions: null |
There was a problem hiding this comment.
I guess this explains why I'm seeing an error when deploying my operator :-)
There was a problem hiding this comment.
This is fixed in version 1.0.1 of the operator SDK.
There was a problem hiding this comment.
This one seems to have missed the v1.0.1 train.
There was a problem hiding this comment.
There was a problem hiding this comment.
My mistake - the commit isn't in v1.0.1 of the SDK.
| @@ -185,15 +193,11 @@ spec: | |||
| - UPDATE | |||
| resources: | |||
| - webhooktests | |||
| sideEffects: None | |||
| sideEffects: null | |||
There was a problem hiding this comment.
And once I manually fix the admissionReviewVersions in my bundle, I get a message about this field being invalid as well.
There was a problem hiding this comment.
This is fixed in version 1.0.1 of the operator SDK.
| @@ -16,3 +16,4 @@ spec: | |||
| namespace: webhook-operator-system | |||
| name: webhook-service | |||
| path: /convert | |||
| port: 443 | |||
There was a problem hiding this comment.
Without this, I get a message like this:
WARN[0000] Warning: Value webhook.operators.coreos.io/v2, Kind=WebhookTest: provided API should have an example annotation
ERRO[0000] Error: Field spec.conversion.webhookClientConfig.service.port, Value 0: spec.conversion.webhookClientConfig.service.port: Invalid value: 0: port is not valid: must be between 1 and 65535, inclusive
make: *** [Makefile:115: bundle] Error 1
There was a problem hiding this comment.
This is a bug that I'll look into - we should be defaulting to 443.
|
I also just tried using diff --git a/bundle/manifests/webhook.operators.coreos.io_webhooktests.yaml b/bundle/manifests/webhook.operators.coreos.io_webhooktests.yaml
index 77146f9..568c71b 100644
--- a/bundle/manifests/webhook.operators.coreos.io_webhooktests.yaml
+++ b/bundle/manifests/webhook.operators.coreos.io_webhooktests.yaml
@@ -3,7 +3,7 @@ kind: CustomResourceDefinition
metadata:
annotations:
cert-manager.io/inject-ca-from: webhook-operator-system/webhook-operator-serving-cert
- controller-gen.kubebuilder.io/version: v0.3.0
+ controller-gen.kubebuilder.io/version: v0.2.5
creationTimestamp: null
name: webhooktests.webhook.operators.coreos.io
spec:
diff --git a/config/crd/bases/webhook.operators.coreos.io_webhooktests.yaml b/config/crd/bases/webhook.operators.coreos.io_webhooktests.yaml
index 1bb7b2e..6d69c2c 100644
--- a/config/crd/bases/webhook.operators.coreos.io_webhooktests.yaml
+++ b/config/crd/bases/webhook.operators.coreos.io_webhooktests.yaml
@@ -4,7 +4,7 @@ apiVersion: apiextensions.k8s.io/v1beta1
kind: CustomResourceDefinition
metadata:
annotations:
- controller-gen.kubebuilder.io/version: v0.3.0
+ controller-gen.kubebuilder.io/version: v0.2.5
creationTimestamp: null
name: webhooktests.webhook.operators.coreos.io
spec: |
|
@awgreene sorry for pinging you directly, but did you have a chance to take a look at this one? |
Based on the discussion from the operator-framework mailing list, I forked your repository and ran
make bundle, resulting in the diff from this PR.Note that I'm using
operator-sdkv1.0.1 andcontroller-genv0.3.0.Signed-off-by: Juraci Paixão Kröhling [email protected]