libmemcached: add MEMCACHED_BEHAVIOR_META_PROTOCOL #112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m6w6
force-pushed
the
feature/meta-commands
branch
from
d02c98c
to
082ff30
Compare
|
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## v1.x #112 +/- ##
======================================
- Coverage 68% 68% -0%
======================================
Files 194 194
Lines 17479 17812 +333
======================================
+ Hits 11930 12150 +220
- Misses 5549 5662 +113 ☔ View full report in Codecov by Sentry. |
m6w6
force-pushed
the
feature/meta-commands
branch
from
082ff30
to
99ab4e8
Compare
m6w6
force-pushed
the
feature/meta-commands
branch
from
902249c
to
81b2016
Compare
bovine
reviewed
Oct 2, 2024
| @@ -96,14 +96,22 @@ memcached_return_t memcached_behavior_set(memcached_st *shell, const memcached_b | |||
| break; | |||
|
|
|||
| case MEMCACHED_BEHAVIOR_BINARY_PROTOCOL: | |||
| send_quit( | |||
| ptr); // We need t shutdown all of the connections to make sure we do the correct protocol | |||
| // We need t shutdown all of the connections to make sure we do the correct protocol | |||
There was a problem hiding this comment.
Suggested change
| // We need t shutdown all of the connections to make sure we do the correct protocol | |
| // We need to shutdown all of the connections to make sure we do the correct protocol |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.