Add dispatchOpenEvent method triggered when the list is toggled #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mahdiyazdani could you review this one as well? |
mahdiyazdani
reviewed
Nov 8, 2023
There was a problem hiding this comment.
Thank you for your contribution. Please see my (minor) comments below:
-
To maintain consistency with other event variables in the library, I recommend renaming the variable to
toggleEvent. -
Additionally, the event name should align with the naming convention used for other events in the library. You might consider renaming it to
wpforms_multiselect_checkbox_list_togglefor better consistency.
|
thank you Mahdi, for the review, I applied suggested changes, please check again |
mahdiyazdani
approved these changes
Nov 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
dispatchOpenEventmethod triggered when the list is toggledYou can see how it is being used in https://github.com/awesomemotive/wpforms-plugin/pull/8341/commits/5948bad23d7209c8f4aced402fd13750e2527dab (admin.js file)