LC_CTYPE replaced with LC_ALL #3492
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
why? |
They want date and time to be shown using a Spanish locale and set the appropriate settings/environment variables. Side note: The proposed patch is actually something that GLib recommends doing to be user-locale aware. |
that kind of link was smth i was expecting to be present as PR reasoning :) |
actionless
approved these changes
Nov 3, 2021
Codecov Report
@@ Coverage Diff @@
## master #3492 +/- ##
==========================================
- Coverage 90.25% 90.25% -0.01%
==========================================
Files 822 822
Lines 53558 53561 +3
==========================================
Hits 48339 48339
- Misses 5219 5222 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Aire-One
approved these changes
Nov 5, 2021
actionless
pushed a commit
to actionless/awesome
that referenced
this pull request
Jun 29, 2022
actionless
pushed a commit
to actionless/awesome
that referenced
this pull request
May 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
LC_CTYPEreplaced withLC_ALL, insetlocaleExplanation
As the docs explain in textclock widget, GLIB should format the date according to the locale.
In my case, the locale is
LANG = es_NI.UTF-8andLANGUAGE = es_ES. And therefore, date format should be in spanish, but AwesomeWM does not format in that way, it's just english.In the image below, you can see the actual behavior (wibar above), which uses
setlocale(LC_CTYPE, ""), and the expected behavior (wibar below), that usessetlocale(LC_ALL, ""), withwibox.widget.textclock("%a %B %Y - %H:%M")