Merge pull request #7 from awendt/strict-asserts

chore: tests use strict asserts only
awendt · Nov 9, 2024 · 0d63ad1 · 0d63ad1
2 parents 0ab09a3 + 9c8962d
commit 0d63ad1
Show file tree

Hide file tree

Showing 7 changed files with 11 additions and 11 deletions.
diff --git a/test/batch-requests.js b/test/batch-requests.js
@@ -1,4 +1,4 @@
-import assert from 'node:assert';
+import assert from 'node:assert/strict';
 import { describe, it, beforeEach, afterEach, mock } from 'node:test';
 import { FetchInterceptor } from '@mswjs/interceptors/fetch'
 import { GitHubClient } from '../lib/client.js';

diff --git a/test/has-new-notifications.js b/test/has-new-notifications.js
@@ -1,4 +1,4 @@
-import assert from 'node:assert';
+import assert from 'node:assert/strict';
 import { describe, it, beforeEach, afterEach } from 'node:test';
 import { FetchInterceptor } from '@mswjs/interceptors/fetch'
 import { GitHubClient } from '../lib/client.js';
@@ -50,7 +50,7 @@ describe('checking for new notifications', async () => {
 
     describe('when HEAD request responds with 304', async () => {
       beforeEach(() => {
-        headResponse = new Response(null, { status: 304, headers: { 'x-poll-interval': 123 } });
+        headResponse = new Response(null, { status: 304, headers: { 'x-poll-interval': '123' } });
       });
 
       it('has no new notifications', async () => {
@@ -65,13 +65,13 @@ describe('checking for new notifications', async () => {
 
         await github.notifications();
         await github.hasNewNotifications();
-        assert.equal(github.pollInterval, 123);
+        assert.equal(github.pollInterval, '123');
       });
     });
 
     describe('when HEAD request responds with 200', async () => {
       beforeEach(() => {
-        headResponse = Response.json( [], { status: 200, headers: { 'X-Poll-Interval': 123 } });
+        headResponse = Response.json( [], { status: 200, headers: { 'X-Poll-Interval': '123' } });
       });
 
       it('has new notifications', async () => {
@@ -86,7 +86,7 @@ describe('checking for new notifications', async () => {
 
         await github.notifications();
         await github.hasNewNotifications();
-        assert.equal(github.pollInterval, 123);
+        assert.equal(github.pollInterval, '123');
       });
     });
 

diff --git a/test/me.js b/test/me.js
@@ -1,4 +1,4 @@
-import assert from 'node:assert';
+import assert from 'node:assert/strict';
 import { describe, it, beforeEach, afterEach } from 'node:test';
 import { FetchInterceptor } from '@mswjs/interceptors/fetch'
 import { GitHubClient } from '../lib/client.js';

diff --git a/test/notifications.js b/test/notifications.js
@@ -1,4 +1,4 @@
-import assert from 'node:assert';
+import assert from 'node:assert/strict';
 import { describe, it, beforeEach, afterEach } from 'node:test';
 import { FetchInterceptor } from '@mswjs/interceptors/fetch'
 import { GitHubClient } from '../lib/client.js';

diff --git a/test/options.js b/test/options.js
@@ -1,4 +1,4 @@
-import assert from 'node:assert';
+import assert from 'node:assert/strict';
 import { describe, it, beforeEach, afterEach } from 'node:test';
 import { FetchInterceptor } from '@mswjs/interceptors/fetch'
 import { GitHubClient } from '../lib/client.js';

diff --git a/test/reducer.js b/test/reducer.js
@@ -1,4 +1,4 @@
-import assert from 'node:assert';
+import assert from 'node:assert/strict';
 import { describe, it } from 'node:test';
 import { NotificationReducer } from '../lib/notification-reducer.js';
 

diff --git a/test/unsubscribe.js b/test/unsubscribe.js
@@ -1,4 +1,4 @@
-import assert from 'node:assert';
+import assert from 'node:assert/strict';
 import { describe, it, beforeEach, afterEach } from 'node:test';
 import { FetchInterceptor } from '@mswjs/interceptors/fetch'
 import { GitHubClient } from '../lib/client.js';