-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expose DOT-specific keywords #4
Comments
I agree, it would be safer to have all the attributes so stringly typed. We could make type safe and constrained methods to build the map[string]string and not break the current API. This is quite a long list of things to implement and, unfortunately, I am currently very busy, but I would be open to contribution. |
Thanks for the answer! No worries, it's good that you agree about the issue. I might submit a PR if time permits it.:) |
I look forward to it :) On 20 March 2015 at 12:30, Michail Kargakis [email protected]
|
I have decided that we are going to make a breaking change to return some errors. |
Merged pull request #25 with some attribute validation. |
A user shouldn't manually construct DOT keywords before adding them in the attributes of a graph object. All the names mentioned in here should be exposed by this package.
The text was updated successfully, but these errors were encountered: