Add support composer 2 and php 8.0 #33
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace `fzaninotto/faker` to `fakerphp/faker` (avtocod#31)
|
поставь все галочки) |
IgorKorytin
suggested changes
May 13, 2021
There was a problem hiding this comment.
- Remove
--no-suggestkey from composer scripts where key-nused (makefile, github actions) - Add
-e 'XDEBUG_MODE=coverage'tomake test-coverscript, and add this env to github actions - Do you check
make test-coverscpipt on PHP 8 andlatestconfig? Think it will not work or u'll get a deprecated warning
| @@ -4,7 +4,7 @@ ENV \ | |||
| COMPOSER_ALLOW_SUPERUSER="1" \ | |||
| @@ -13,7 +13,6 @@ RUN set -x \ | |||
| && pecl install xdebug-2.9.6 1>/dev/null \ | |||
| && apk del .build-deps \ | |||
| && mkdir /src ${COMPOSER_HOME} \ | |||
| && composer global require 'hirak/prestissimo' --no-interaction --no-suggest --prefer-dist \ | |||
There was a problem hiding this comment.
Remove it from github actions workflow too please
| @@ -15,16 +15,16 @@ | |||
| } | |||
| ], | |||
| "require": { | |||
| "php": "^7.2", | |||
| "php": "^7.2 || ^8.0", | |||
There was a problem hiding this comment.
change php version in Dockerfile and add php 8 to github actions
| @@ -13,7 +13,6 @@ RUN set -x \ | |||
| && pecl install xdebug-2.9.6 1>/dev/null \ | |||
|
@4irik |
|
No activity |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add support composer 2 and php 8.0
Fixes #30
Checklist
CHANGELOG.mdfile