Fixing a regression in hypermedia() regarding pagination - returnin…

…g original `or` for `NaN` outputs of `Number()`

lib/utility.js

@@ -545,8 +545,8 @@ function hypermedia (server, req, rep, headers) {
 	}
 
 	query = req.parsed.searchParams;
-	page = Number(query.get("page"));
-	page_size = Number(query.get("page_size"));
+	page = Number(query.get("page")) || 1;
+	page_size = Number(query.get("page_size")) || server.config.pageSize || 5;
 
 	if (page < 1) {
 		page = 1;

package.json

@@ -1,7 +1,7 @@
 {
   "name": "tenso",
   "description": "Tensō is an HTTP/HTTP2 REST API framework",
-  "version": "12.0.7",
+  "version": "12.0.8",
   "homepage": "http://avoidwork.github.io/tenso",
   "author": "Jason Mulligan <[email protected]>",
   "repository": {

test/behavior_test.js

@@ -45,6 +45,19 @@ describe("Pagination", function () {
 			.end();
 	});
 
+	it("GET /items?page=a&page_size=b - returns page 1/3 of an array of numbers", function () {
+		return tinyhttptest({url: "http://localhost:" + port + "/items?page=a&page_size=b"})
+			.expectStatus(200)
+			.expectValue("links", [{"uri": "/", "rel": "collection"}, {
+				"uri": "/items?page=3&page_size=5",
+				"rel": "last"
+			}, {"uri": "/items?page=2&page_size=5", "rel": "next"}])
+			.expectValue("data", [1, 2, 3, 4, 5])
+			.expectValue("error", null)
+			.expectValue("status", 200)
+			.end();
+	});
+
 	it("GET /items?page=0&page_size=5 - returns page 1/3 of an array of numbers", function () {
 		return tinyhttptest({url: "http://localhost:" + port + "/items?page=0&page_size=5"})
 			.expectStatus(200)

test/behavior_test2.js

@@ -40,6 +40,19 @@ describe("Pagination (HTTP2)", function () {
 			.end();
 	});
 
+	it("GET /items?page=a&page_size=b - returns page 1/3 of an array of numbers", function () {
+		return tinyhttptest({http2: true, url: `https://localhost:${port}/items?page=a&page_size=b`})
+			.expectStatus(200)
+			.expectValue("links", [{"uri": "/", "rel": "collection"}, {
+				"uri": "/items?page=3&page_size=5",
+				"rel": "last"
+			}, {"uri": "/items?page=2&page_size=5", "rel": "next"}])
+			.expectValue("data", [1, 2, 3, 4, 5])
+			.expectValue("error", null)
+			.expectValue("status", 200)
+			.end();
+	});
+
 	it("GET /items?page=0&page_size=5 - returns page 1/3 of an array of numbers", function () {
 		return tinyhttptest({http2: true, url: `https://localhost:${port}/items?page=0&page_size=5`})
 			.expectStatus(200)