Decoding order_by query string value before passing to keysort()

avoidwork · Dec 17, 2018 · 40b2134 · 40b2134
1 parent 39e08e5
commit 40b2134
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/lib/utility.js b/lib/utility.js
@@ -631,7 +631,7 @@ function sort (arg, req) {
 
 	if (typeof req.parsed.search === "string" && req.parsed.searchParams.has("order_by") && Array.isArray(arg)) {
 		if (regex.unsortable.test(typeof arg[0]) === false && arg[0] !== null) {
-			output = keysort(clone(arg), req.parsed.search.replace("?", "").split("&").filter(i => regex.orderBy.test(i)).reduce((a, b) => [...a, b.replace(regex.orderBy, "")], []).join(", ").replace(/\%20|\+/g, " "));
+			output = keysort(clone(arg), req.parsed.search.replace("?", "").split("&").filter(i => regex.orderBy.test(i)).reduce((a, b) => [...a, decodeURIComponent(b.replace(regex.orderBy, ""))], []).join(", "));
 		} else {
 			// Primitives, regular Array.sort()
 			output = clone(arg).sort(retsu.sort);

diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -1,7 +1,7 @@
 {
   "name": "tenso",
   "description": "Tensō is an HTTP/HTTP2 REST API framework",
-  "version": "10.0.8",
+  "version": "10.0.9",
   "homepage": "http://avoidwork.github.io/tenso",
   "author": "Jason Mulligan <[email protected]>",
   "repository": {