Mail Results - Disable Plugin #6001
Conversation
harvey0100
force-pushed
the
GmailPlugin
branch
from
cff205c to
af8605c
Compare
There was a problem hiding this comment.
Hi @harvey0100 ,
Thanks for this. It seems to do what's needed, but as you can see in the inline comment, it looks like there's some duplication of similar code.
Please let me know if I'm missing something.
Thanks again!
| @@ -160,6 +160,10 @@ def _send_email(smtp, sender, rcpt, msg): | |||
|
|
|||
| @staticmethod | |||
| def _smtp_login_and_send(job, msg): | |||
| if not job.config.get("plugins.mail.server"): | |||
There was a problem hiding this comment.
Can you explain why only plugins.mail.server is checked here? AFAICT, all of the configuration (server, port, sender, password) will be needed, right?
If that's the case, a check such as:
server, port, sender, password = Mail._get_smtp_config(job)
if not all([server, port, sender, password]):
...That suggestion of mine looks a lot _validate_email_config() so it seems like it could be refactored a bit and used here too.
There was a problem hiding this comment.
Hi Cleber, thanks for the feedback i've implemented the validate email config inside of login_and_send to refactor now. Looks like it is all working as intended :)
harvey0100
force-pushed
the
GmailPlugin
branch
from
af8605c to
12e255e
Compare
Plugin was attemtping SMTP connections regardless of if the plugin config was using defaults. Now checks on pre/post checks to stop attempted SMTP connections before the plugin was disabled. Signed-off-by: Harvey Lynden <[email protected]>
harvey0100
force-pushed
the
GmailPlugin
branch
from
12e255e to
4450fd7
Compare
Plugin was attempting SMTP connections regardless
of if the plugin config was using defaults.
Now checks on pre/post checks to stop attempted
SMTP connections before the plugin was disabled.